[jira] [Commented] (OOZIE-3081) testSubmitWithLauncherQueue fails when FairScheduler is used

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198522#comment-16198522 ] 

Hadoop QA commented on OOZIE-3081:
----------------------------------

Testing JIRA OOZIE-3081

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 2039
.    Tests rerun: 72
.    Tests failed at first run: org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/95/

> testSubmitWithLauncherQueue fails when FairScheduler is used
> ------------------------------------------------------------
>
>                 Key: OOZIE-3081
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3081
>             Project: Oozie
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 5.0.0
>            Reporter: Attila Sasvari
>            Assignee: Attila Sasvari
>            Priority: Trivial
>         Attachments: OOZIE-3081-001.patch
>
>
> Running TestJavaActionExecutor fails with fair scheduler
> {code}
> Failed tests: testSubmitWithLauncherQueue(org.apache.oozie.action.hadoop.TestJavaActionExecutor): 
>  expected:<[]test> but was:<[root.]test>
> {code}
> Reason: FairScheduler adds a "root." prefix to the queue name in [org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.ensureRootPrefix()|https://github.com/apache/hadoop/blob/99292adcefdc6b8f280b8e100605fb39f755c38a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java#L165]
> A potential way to fix the test case:
> - we can add a new function 
> {code}
>     private boolean isFairSchedulerUsed(Configuration conf) {
>         return conf.get("yarn.resourcemanager.scheduler.class").contains(FairScheduler.class.getName());
>     }
> {code}
> that can be called from {{testSubmitWithLauncherQueue()}}:
> {code}
> ...
>         if (isFairSchedulerUsed(conf)) {
>             assertEquals("root.test", queue);
>         }
>         else {
>             assertEquals("test", queue);
>         }
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)