You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lucky-chen <gi...@git.apache.org> on 2018/05/30 13:07:50 UTC

[GitHub] incubator-weex pull request #1227: [WEEX-420][iOS] Try to resolve multithrea...

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1227

    [WEEX-420][iOS] Try to resolve multithread crash during delete layoutNode

    -  history issue 
        - delete node should be in domthread ,now ui thread (due to the ARC)
    - rm ref childRef & parent ref when delete node (cause node point EXC-BAD-ACCESS)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex ios-bugfix-recycleNode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1227
    
----
commit c6c77d7df37bee6f8edf261c2b78207abf7f9ab1
Author: zhongcang <qh...@...>
Date:   2018-05-30T12:58:44Z

    * [iOS] Try to resolve multithread crash during delete layoutNode

----


---

[GitHub] incubator-weex issue #1227: [WEEX-420][iOS] Try to resolve multithread crash...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1227
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1227: [WEEX-420][iOS] Try to resolve multithrea...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1227


---