You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bogdanrdc <gi...@git.apache.org> on 2017/02/22 12:35:52 UTC
[GitHub] spark pull request #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved...
GitHub user bogdanrdc opened a pull request:
https://github.com/apache/spark/pull/17026
[SPARK-13721][SQL] Make GeneratorOuter unresolved.
## What changes were proposed in this pull request?
This is a small change to make GeneratorOuter always unresolved. It is mostly no-op change but makes it more clear since GeneratorOuter shouldn't survive analysis phase.
This requires also handling in ResolveAliases rule.
## How was this patch tested?
Existing generator tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bogdanrdc/spark PR16958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17026.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17026
----
commit 2cb75525a90a8400228f344a82dde8f3ffe4422f
Author: Reynold Xin <rx...@databricks.com>
Date: 2017-02-16T15:02:45Z
[SPARK-13721][SQL] Make GeneratorOuter unresolved.
commit 4e819a0deef906d14e884685f784ae649133dff6
Author: Bogdan Raducanu <bo...@databricks.com>
Date: 2017-02-22T12:28:28Z
fix ResolveAliases
commit 5e25c63569a0e1d0018aff2d2790bdf84f45b34c
Author: Bogdan Raducanu <bo...@databricks.com>
Date: 2017-02-22T12:29:24Z
Merge remote-tracking branch 'upstream/master' into PR16958
commit c6e8807338b76239afb3ebbb7b9a57b1bb362cc9
Author: Bogdan Raducanu <bo...@databricks.com>
Date: 2017-02-22T12:30:59Z
space
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17026
**[Test build #73276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73276/testReport)** for PR 17026 at commit [`c6e8807`](https://github.com/apache/spark/commit/c6e8807338b76239afb3ebbb7b9a57b1bb362cc9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73276/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17026
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by bogdanrdc <gi...@git.apache.org>.
Github user bogdanrdc commented on the issue:
https://github.com/apache/spark/pull/17026
cc @rxin @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17026
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17026
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17026: [SPARK-13721][SQL] Make GeneratorOuter unresolved.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17026
**[Test build #73276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73276/testReport)** for PR 17026 at commit [`c6e8807`](https://github.com/apache/spark/commit/c6e8807338b76239afb3ebbb7b9a57b1bb362cc9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org