You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dramaticlly (via GitHub)" <gi...@apache.org> on 2026/08/17 19:43:14 UTC
[PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
dramaticlly opened a new pull request, #17704:
URL: https://github.com/apache/iceberg/pull/17704
Removes `HadoopFileIO(SerializableSupplier<Configuration>)`, deprecated for removal in 1.12.0 in favor of `HadoopFileIO(Configuration)` from #15583
## AI Disclosure
Model: Claude Opus 5 (1M context)
Platform/Tool: Claude Code
Human Oversight: reviewed
Prompt Summary: split #16449 into smaller self-contained PRs; verify each group compiles and tests green standalone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17704:
URL: https://github.com/apache/iceberg/pull/17704#discussion_r3801613081
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -138,10 +129,6 @@ public Configuration getConf() {
return hadoopConf.get();
}
- /**
- * @deprecated since 1.11.0, will be removed in 1.12.0.
- */
- @Deprecated
Review Comment:
This un-deprecation seems like the correct fix here, right? `serializeConfWith` is a non-default abstract method on the HadoopConfigurable interface (itself not deprecated) and is called by SerializationUtil, Spark's SerializableFileIOWithSize, and mr.IcebergInputFormat, so it can't be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on PR #17704:
URL: https://github.com/apache/iceberg/pull/17704#issuecomment-5372788743
@nastra @huaxingao if you can help take a look at this one, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on code in PR #17704:
URL: https://github.com/apache/iceberg/pull/17704#discussion_r3798324665
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -138,10 +129,6 @@ public Configuration getConf() {
return hadoopConf.get();
}
- /**
- * @deprecated since 1.11.0, will be removed in 1.12.0.
- */
- @Deprecated
Review Comment:
@nastra I drop this @deprecated annotation because HadoopFileIO today implements HadoopConfigurable interface and the `serializeConfWith` is still defined on the interface.
If you want, we can also deprecate `serializeConfWith` on `HadoopConfigurable` and also its implementations (`ResolvingFileIO` and `SerializableFileIOWithSize`) for 1.13.0. I would also expect the change in SerializationUtil and IcebergInputFormat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #17704:
URL: https://github.com/apache/iceberg/pull/17704#issuecomment-5407433579
Thanks @dramaticlly for the PR! Thanks @uros-b for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Remove deprecated HadoopFileIO(SerializableSupplier) constructor [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao merged PR #17704:
URL: https://github.com/apache/iceberg/pull/17704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org