[Impala-ASF-CR] IMPALA-12066: Avoid missing updates due to skipping

["ttttttz (Code Review)" <ge...@cloudera.org>]

Hello Quanlong Huang, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19751

to look at the new patch set (#4).

Change subject: IMPALA-12066: Avoid missing updates due to skipping
......................................................................

IMPALA-12066: Avoid missing updates due to skipping

In the CatalogServiceCatalog#lockHdfsTblWithTimeout()
method, we think it's safe to skip the table when the
gathering thread cannot get a read lock in attempt 2.
This is not entirely correct because it's not guarantee
that the tbl version will be updated outside current
window of the topic updates when the mutating thread
fails for some reasons.This change avoids topic-update
thread missing updates by setting the maximum delay
time of topic updates for a table due to lock contention.

This change introduces 1 new configurations for catalogd:
1. catalog_max_lock_delay_topic_updates: This defines
the maximum delay time of topic updates for a table due to
lock contention in catalogd after which it must be added
to the topic the update log.

Change-Id: I1a21edaea21b95723e567ddee5e1f857c0e2b087
---
M be/src/catalog/catalog-server.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
6 files changed, 45 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/19751/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a21edaea21b95723e567ddee5e1f857c0e2b087
Gerrit-Change-Number: 19751
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>