You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/01/18 23:04:24 UTC
svn commit: r735555 - in /hadoop/hbase/trunk: CHANGES.txt
src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
Author: stack
Date: Sun Jan 18 14:04:24 2009
New Revision: 735555
URL: http://svn.apache.org/viewvc?rev=735555&view=rev
Log:
HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another spin on HBASE-930)
Modified:
hadoop/hbase/trunk/CHANGES.txt
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=735555&r1=735554&r2=735555&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Sun Jan 18 14:04:24 2009
@@ -145,6 +145,8 @@
not already marked as pending close
HBASE-1124 Balancer kicks in way too early
HBASE-1127 OOME running randomRead PE
+ HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another
+ spin on HBASE-930)
IMPROVEMENTS
HBASE-901 Add a limit to key length, check key and value length on client side
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java?rev=735555&r1=735554&r2=735555&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java Sun Jan 18 14:04:24 2009
@@ -68,14 +68,18 @@
}
} catch (FailedLogCloseException e) {
LOG.fatal("Forcing server shutdown", e);
+ server.checkFileSystem();
server.abort();
} catch (java.net.ConnectException e) {
LOG.fatal("Forcing server shutdown", e);
+ server.checkFileSystem();
server.abort();
} catch (IOException ex) {
- LOG.error("Log rolling failed with ioe: ",
- RemoteExceptionHandler.checkIOException(ex));
+ LOG.fatal("Log rolling failed with ioe: ",
+ RemoteExceptionHandler.checkIOException(ex));
server.checkFileSystem();
+ // Abort if we get here. We probably won't recover an IOE. HBASE-1132
+ server.abort();
} catch (Exception ex) {
LOG.error("Log rolling failed", ex);
server.checkFileSystem();
@@ -123,4 +127,4 @@
rollLock.unlock();
}
}
-}
\ No newline at end of file
+}