[GitHub] [spark] LielBach commented on a change in pull request #31238: [SPARK-32194][PYTHON] Add more refined pyspark exceptions

[GitBox <gi...@apache.org>]

LielBach commented on a change in pull request #31238:
URL: https://github.com/apache/spark/pull/31238#discussion_r576464451



##########
File path: python/pyspark/exceptions.py
##########
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+class NonDriverReferenceError(Exception):
+    """
+    Thrown when trying to reference a driver's value or attribute in a non driver environment.
+    """
+
+
+class JavaGatewayError(Exception):
+    """
+        Indicates an error of the java gateway.
+    """
+
+
+class SparkContextInitializationError(RuntimeError):

Review comment:
       Yes I can see your point about the complex hierarchy and I've committed a revision that merges both of the Spark Context's exceptions. With that said I think that the relative complexity and possibilities of errors thrown when initializing a spark context does merit an exception class of its own




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org