You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/05 09:05:07 UTC
[GitHub] [pulsar] aloyszhang opened a new pull request #7181: add topic type validation before update topic partitions
aloyszhang opened a new pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181
Fixes #7152
### Motivation
This PR add topic type validation before update partition numbers of partitioned-topic.
This can prevent creating new partitions for non-partitoned topics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#issuecomment-639559516
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on a change in pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on a change in pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#discussion_r436427205
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -252,9 +252,9 @@ public void createNonPartitionedTopic(
* well. Therefore, it can violate partition ordering at producers until all producers are restarted at application.
*
* @param tenant
- * @param cluster
* @param namespace
- * @param topic
+ * @param namespace
Review comment:
will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#issuecomment-640416163
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#issuecomment-640535231
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on a change in pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on a change in pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#discussion_r436399856
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -252,9 +252,9 @@ public void createNonPartitionedTopic(
* well. Therefore, it can violate partition ordering at producers until all producers are restarted at application.
*
* @param tenant
- * @param cluster
* @param namespace
- * @param topic
+ * @param namespace
Review comment:
This line is duplicated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7181: add topic type validation before update topic partitions
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7181:
URL: https://github.com/apache/pulsar/pull/7181#issuecomment-640361042
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org