You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/02 14:05:23 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #351:
[ISSUE #344] feat(client): advance timeout
xujianhai666 opened a new pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351
- use ctx timeout for remoting Client
- use ctx timeout for rmqClient
Closes #344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #351: [ISSUE
#344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #351:
[ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#issuecomment-570456602
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=h1) Report
> Merging [#351](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `20.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #351 +/- ##
==========================================
- Coverage 26.28% 26.27% -0.02%
==========================================
Files 47 47
Lines 5535 5522 -13
==========================================
- Hits 1455 1451 -4
+ Misses 3889 3880 -9
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/mock\_namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19uYW1lc3J2Lmdv) | `0% <0%> (ø)` | :arrow_up: |
| [internal/mock\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19jbGllbnQuZ28=) | `0% <0%> (ø)` | :arrow_up: |
| [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `31.02% <0%> (-0.13%)` | :arrow_down: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (-0.01%)` | :arrow_down: |
| [internal/remote/mock\_remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL21vY2tfcmVtb3RlX2NsaWVudC5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.59% <100%> (+0.28%)` | :arrow_up: |
| [internal/remote/future.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2Z1dHVyZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `50.79% <100%> (ø)` | :arrow_up: |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.9% <100%> (+0.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=footer). Last update [598c979...75864c6](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull
request #351: [ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#discussion_r362701936
##########
File path: internal/mock_namesrv.go
##########
@@ -1,30 +1,15 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
// Code generated by MockGen. DO NOT EDIT.
Review comment:
@wenfengwang done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang commented on a change in pull
request #351: [ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on a change in pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#discussion_r362697754
##########
File path: internal/mock_client.go
##########
@@ -1,19 +1,3 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
// Code generated by MockGen. DO NOT EDIT.
Review comment:
Apache License header missing, please add it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang commented on a change in pull
request #351: [ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on a change in pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#discussion_r362697780
##########
File path: internal/mock_namesrv.go
##########
@@ -1,30 +1,15 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
// Code generated by MockGen. DO NOT EDIT.
Review comment:
Apache License header missing, please add it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang commented on a change in pull
request #351: [ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on a change in pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#discussion_r362697803
##########
File path: internal/remote/mock_remote_client.go
##########
@@ -1,19 +1,3 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
Review comment:
Apache License header missing, please add it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull
request #351: [ISSUE #344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#discussion_r362701921
##########
File path: internal/remote/mock_remote_client.go
##########
@@ -1,19 +1,3 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
Review comment:
done @wenfengwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #351: [ISSUE
#344] feat(client): advance timeout
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #351: [ISSUE #344] feat(client): advance timeout
URL: https://github.com/apache/rocketmq-client-go/pull/351#issuecomment-570456602
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=h1) Report
> Merging [#351](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/598c979ebd6db2212776e8e38d7f623090360481?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `20.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #351 +/- ##
==========================================
- Coverage 26.28% 26.27% -0.02%
==========================================
Files 47 47
Lines 5535 5522 -13
==========================================
- Hits 1455 1451 -4
+ Misses 3889 3880 -9
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/mock\_namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19uYW1lc3J2Lmdv) | `0% <0%> (ø)` | :arrow_up: |
| [internal/mock\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19jbGllbnQuZ28=) | `0% <0%> (ø)` | :arrow_up: |
| [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `31.02% <0%> (-0.13%)` | :arrow_down: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (-0.01%)` | :arrow_down: |
| [internal/remote/mock\_remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL21vY2tfcmVtb3RlX2NsaWVudC5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.59% <100%> (+0.28%)` | :arrow_up: |
| [internal/remote/future.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2Z1dHVyZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `50.79% <100%> (ø)` | :arrow_up: |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/351/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.9% <100%> (+0.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=footer). Last update [598c979...75864c6](https://codecov.io/gh/apache/rocketmq-client-go/pull/351?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services