[GitHub] [arrow-rs] ByteBaker commented on issue #3300: Add support for content-type while uploading files through ObjectStore API

[GitBox <gi...@apache.org>]

ByteBaker commented on issue #3300:
URL: https://github.com/apache/arrow-rs/issues/3300#issuecomment-1343785027

   I think so, yes. Because the first problem I faced was the inability to make any changes to the HTTP client, since that's where one would add any header.
   
   In the changes I've made, I was able to add it to the trait itself, but had to ignore the **content_type** argument for local file system by underscoring it. Even though it works without any problems, I'm afraid its presence will confuse users using local file system as the backend.
   
   In such a case, should I write the code for the solution you've proposed above? I think it's rather straightforward with one question. 
   
   What's the purpose of having both `mime` and `extension` in `fn with_content_type_for_suffix(self, mime: impl Into<String>, extension: impl Into<String>)`? I mean, couldn't we have a mime type for the given file type anyway?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org