[GitHub] [inlong] EMsnap commented on a diff in pull request #6175: [INLONG-6045][Sort] Sort support all migrate for Oracle connector

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #6175:
URL: https://github.com/apache/inlong/pull/6175#discussion_r996656309


##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleTableSource.java:
##########
@@ -130,13 +129,14 @@ public ScanRuntimeProvider getScanRuntimeProvider(ScanContext scanContext) {
                         .setResultTypeInfo(typeInfo)
                         .setUserDefinedConverterFactory(
                                 OracleDeserializationConverterFactory.instance())
+                        .setMigrateAll(migrateAll)
                         .build();
         OracleSource.Builder<RowData> builder =
                 OracleSource.<RowData>builder()
                         .hostname(hostname)
                         .port(port)
                         .database(database)
-                        .tableList(schemaName + "." + tableName)
+                        .tableList(tableName)

Review Comment:
   manager should change the parameter rules noted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org