You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/06/19 00:43:40 UTC

Review Request 22762: Fix concurrent modification exception in Sender.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22762/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1316
    https://issues.apache.org/jira/browse/KAFKA-1316


Repository: kafka


Description
-------

KAFKA-1316 Follow-up patch for concurrent modification exception.


Diffs
-----

  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java c67b947c464ec86e28fbdf35af811e5e40f22a7a 

Diff: https://reviews.apache.org/r/22762/diff/


Testing
-------


Thanks,

Jay Kreps

Re: Review Request 22762: Patch for KAFKA-1316

Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22762/
-----------------------------------------------------------

(Updated June 19, 2014, 9:01 p.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1316


Bugs: KAFKA-1316
    https://issues.apache.org/jira/browse/KAFKA-1316


Repository: kafka


Description (updated)
-------

KAFKA-1291 Add wrapper scripts and usage information to each command.


Diffs (updated)
-----

  bin/kafka-consumer-offset-checker.sh PRE-CREATION 
  bin/kafka-replica-verification.sh PRE-CREATION 
  bin/kafka-simple-consumer-perf-test.sh b1a5cfcdb50b2c885e4cb4c4848c205c1d279396 
  bin/windows/kafka-consumer-offset-checker.bat PRE-CREATION 
  bin/windows/kafka-consumer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-mirror-maker.bat PRE-CREATION 
  bin/windows/kafka-preferred-replica-election.bat PRE-CREATION 
  bin/windows/kafka-producer-perf-test.bat PRE-CREATION 
  bin/windows/kafka-reassign-partitions.bat PRE-CREATION 
  bin/windows/kafka-replay-log-producer.bat PRE-CREATION 
  bin/windows/kafka-replica-verification.bat PRE-CREATION 
  bin/windows/kafka-simple-consumer-shell.bat PRE-CREATION 
  bin/windows/zookeeper-shell.bat PRE-CREATION 
  core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 9b3c6aeaf77db6cea75272c60a42fa45955fed5b 
  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 2637586af99cf8a6c4ea3a4ccb244d1e76f0f81a 
  core/src/main/scala/kafka/admin/TopicCommand.scala 6788c2edef91a0aef28f1cb5e3fc477d9b9f2d67 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala f6bc2f1579580574bc66ec6463eafe21ffb311f9 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala f4e07d4bb4e264479e196aa805018413104acebd 
  core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
  core/src/main/scala/kafka/tools/ConsumerPerformance.scala 46883493e04877f3e19892ecb73015d0335d51a1 
  core/src/main/scala/kafka/tools/DumpLogSegments.scala f0ab02a4e6dd1b945b263607c26ae22f00e6b158 
  core/src/main/scala/kafka/tools/ExportZkOffsets.scala 005231f38dd9cea60ec953a28a1ab57d3e316eed 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f 
  core/src/main/scala/kafka/tools/ImportZkOffsets.scala c8023ee60c07b6e59906da9331bd5d764fd60cba 
  core/src/main/scala/kafka/tools/JmxTool.scala 747a675455e9aee4f7c124abe78e0454e72f0b18 
  core/src/main/scala/kafka/tools/MirrorMaker.scala e75c4f8e8070c558caa8fe9a932729d26d9807db 
  core/src/main/scala/kafka/tools/ProducerPerformance.scala 95cfbc1d24820a10dbe03613c03c5ec12aadc4dc 
  core/src/main/scala/kafka/tools/ReplayLogProducer.scala eb71e49a8f16be1422ced60c66e43d7f99943607 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 
  core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 8b8c4726ab04e109402d80435459ffc691d087ca 
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e 
  core/src/main/scala/kafka/tools/StateChangeLogMerger.scala 97970fb941fafb04ae351e99bf1a4ff3c8e0d322 
  core/src/main/scala/kafka/tools/TestLogCleaning.scala 595dc7ca17b6e43605285d74c4a3f4f2da2a72b3 
  core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala 92c0d1f979fba3496d1f092cc073073dcf4447e6 
  core/src/main/scala/kafka/utils/CommandLineUtils.scala c1d8ba5422f42529e6e1636157eb3a50d1bbdb44 
  core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala eeb8c8856200c5b2ed5fd8a7b9b28f813eabd67d 

Diff: https://reviews.apache.org/r/22762/diff/


Testing
-------


Thanks,

Jay Kreps

Re: Review Request 22762: Fix concurrent modification exception in Sender.

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22762/#review46175
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On June 18, 2014, 10:43 p.m., Jay Kreps wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22762/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 10:43 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1316
>     https://issues.apache.org/jira/browse/KAFKA-1316
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1316 Follow-up patch for concurrent modification exception.
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java c67b947c464ec86e28fbdf35af811e5e40f22a7a 
> 
> Diff: https://reviews.apache.org/r/22762/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Kreps
> 
>