You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2009/04/07 01:54:13 UTC

[jira] Created: (HIVE-391) udafcount merge does not handle nulls

udafcount merge does not handle nulls
-------------------------------------

                 Key: HIVE-391
                 URL: https://issues.apache.org/jira/browse/HIVE-391
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.3.0
            Reporter: Namit Jain
            Assignee: Namit Jain
            Priority: Blocker


udafcount merge does not handle nulls

If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
it will get a null pointer


select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-391:
----------------------------

    Attachment: hive.391.1.patch

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-391) udafcount merge does not handle nulls

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696341#action_12696341 ] 

Raghotham Murthy commented on HIVE-391:
---------------------------------------

+1 

looks good. Will commit if the tests pass.

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-391) udafcount merge does not handle nulls

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy resolved HIVE-391.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.3.1
     Hadoop Flags: [Reviewed]

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>             Fix For: 0.3.1
>
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-391:
----------------------------

    Status: Open  (was: Patch Available)

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson updated HIVE-391:
---------------------------------

    Fix Version/s:     (was: 0.3.1)
                   0.3.0

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-391:
----------------------------

    Status: Patch Available  (was: Open)

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-391:
----------------------------

    Attachment: hive.391.2.patch

added more tests

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-391) udafcount merge does not handle nulls

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696330#action_12696330 ] 

Raghotham Murthy commented on HIVE-391:
---------------------------------------

can you add a test where there is no map-side aggregate and there is a count distinct? this case will be useful when the cardinality of the distinct column is very high and the data is not partitioned on the distinct column.

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>         Attachments: hive.391.1.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-391) udafcount merge does not handle nulls

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696402#action_12696402 ] 

Raghotham Murthy commented on HIVE-391:
---------------------------------------

Committed to trunk and back-ported to 0.3. Thanks Namit! 

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>             Fix For: 0.3.1
>
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-391) udafcount merge does not handle nulls

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-391:
--------------------------------

    Fix Version/s: 0.4.0
                       (was: 0.3.0)

> udafcount merge does not handle nulls
> -------------------------------------
>
>                 Key: HIVE-391
>                 URL: https://issues.apache.org/jira/browse/HIVE-391
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>            Priority: Blocker
>             Fix For: 0.4.0
>
>         Attachments: hive.391.1.patch, hive.391.2.patch
>
>
> udafcount merge does not handle nulls
> If the mapper does not emit any row on null input, i.e both count and count distinct are present, and the aggregation function is count, 
> it will get a null pointer
> select count(1), count(distinct x.value) from src x where x.key = 9999;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.