You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/14 10:30:08 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2422:
It's to remove `static` of method dataSource,
If not remove `static` the transaction will not work.
codecov-io commented on issue #2422: It's to remove `static` of method dataSource,If not remove `static` the transaction will not work.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2422#issuecomment-613358611
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=h1) Report
> Merging [#2422](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/5185d283f9bea4d0a345b256a080b8fa5ee913f6&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2422 +/- ##
============================================
- Coverage 32.89% 32.88% -0.02%
Complexity 2275 2275
============================================
Files 423 423
Lines 19839 19839
Branches 2366 2366
============================================
- Hits 6527 6524 -3
- Misses 12726 12730 +4
+ Partials 586 585 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...eduler/dao/datasource/SpringConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvU3ByaW5nQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0.00%> (-28.58%)` | `2.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `71.66% <0.00%> (-6.67%)` | `13.00% <0.00%> (-1.00%)` | |
| [...duler/api/utils/exportprocess/DataSourceParam.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL2V4cG9ydHByb2Nlc3MvRGF0YVNvdXJjZVBhcmFtLmphdmE=) | `70.58% <0.00%> (-5.89%)` | `4.00% <0.00%> (ø%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.95% <0.00%> (+2.87%)` | `11.00% <0.00%> (+2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=footer). Last update [5185d28...5db1d6c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2422?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services