You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by cm...@collab.net on 2003/01/24 18:17:03 UTC

Re: svn commit: rev 4562 - trunk/subversion/clients/cmdline

kfogel@tigris.org writes:

 Author: kfogel
 Date: 2003-01-24 11:25:34 -0600 (Fri, 24 Jan 2003)
 New Revision: 4562
 
 Modified:
    trunk/subversion/clients/cmdline/cat-cmd.c
 Log:
 Follow up to revision 4561:
 
 * subversion/clients/cmdline/cat-cmd.c
   (svn_cl__cat): Add a comment about why APR i/o is preferable.

So...are you planning on adding that comment everywhere that function
is called?  Or might it just be better to fix to APR documentation to
list the advantages of using that interface over direct stdio?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4562 - trunk/subversion/clients/cmdline

Posted by Karl Fogel kf...@newton.ch.collab.net.
Bill Tutt rassilon@lyra.org writes:
 Err, I'd just put the comment about why APR i/o is preferrable on
 svn_stream_from_stdio and any other place in APR you feel like. :)

That's a good idea; doing.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: svn commit: rev 4562 - trunk/subversion/clients/cmdline

Posted by Bill Tutt ra...@lyra.org.
Err, I'd just put the comment about why APR i/o is preferrable on
svn_stream_from_stdio and any other place in APR you feel like. :)

Bill
----
Do you want a dangerous fugitive staying in your flat?
No.
Well, don't upset him and he'll be a nice fugitive staying in your flat.
 


 -----Original Message-----
 From: Karl Fogel [mailto:kfogel@newton.ch.collab.net] 
 Sent: Friday, January 24, 2003 10:25 AM
 To: cmpilato@collab.net
 Cc: dev@subversion.tigris.org; rbb@rkbloom.net
 Subject: Re: svn commit: rev 4562 - trunk/subversion/clients/cmdline
 
 
 cmpilato@collab.net writes:
   Follow up to revision 4561:
   
   * subversion/clients/cmdline/cat-cmd.c
     (svn_cl__cat): Add a comment about why APR i/o is preferable.
  
  So...are you planning on adding that comment everywhere 
 that function 
  is called?  Or might it just be better to fix to APR 
 documentation to 
  list the advantages of using that interface over direct stdio?
 
 Sorry, I didn't realize we called it elsewhere (but should 
 have thought to check).
 
 Yeah, fixing the APR documention sounds better.  Will move it to there
 -- no wait, will ask Ryan Bloom if he wants to do it, because 
 I think he might be able to give a more precise statement of 
 the advantages. Ryan?
 
 -Karl
 
 ---------------------------------------------------------------------
 To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
 For additional commands, e-mail: dev-help@subversion.tigris.org
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4562 - trunk/subversion/clients/cmdline

Posted by rb...@rkbloom.net.

On 24 Jan 2003, Karl Fogel wrote:

 cmpilato@collab.net writes:
   Follow up to revision 4561:
  
   * subversion/clients/cmdline/cat-cmd.c
     (svn_cl__cat): Add a comment about why APR i/o is preferable.
 
  So...are you planning on adding that comment everywhere that function
  is called?  Or might it just be better to fix to APR documentation to
  list the advantages of using that interface over direct stdio?

 Sorry, I didn't realize we called it elsewhere (but should have
 thought to check).

 Yeah, fixing the APR documention sounds better.  Will move it to there
 -- no wait, will ask Ryan Bloom if he wants to do it, because I think
 he might be able to give a more precise statement of the advantages.
 Ryan?

When I left the APR development team, I asked to have all of my commit
priviledges removed from the CVS tree.  So, while I would previously have
offered to fix the APR docs (or code), I can't anymore.

Sorry.  But, there are any number of people on the APR list who should be
capable of explaining the differences, so just post to the APR dev list
asking for the docs to be updated.

Ryan


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 4562 - trunk/subversion/clients/cmdline

Posted by Karl Fogel kf...@newton.ch.collab.net.
cmpilato@collab.net writes:
  Follow up to revision 4561:
  
  * subversion/clients/cmdline/cat-cmd.c
    (svn_cl__cat): Add a comment about why APR i/o is preferable.
 
 So...are you planning on adding that comment everywhere that function
 is called?  Or might it just be better to fix to APR documentation to
 list the advantages of using that interface over direct stdio?

Sorry, I didn't realize we called it elsewhere (but should have
thought to check).

Yeah, fixing the APR documention sounds better.  Will move it to there
-- no wait, will ask Ryan Bloom if he wants to do it, because I think
he might be able to give a more precise statement of the advantages.
Ryan?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org