You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jsoref (via GitHub)" <gi...@apache.org> on 2023/07/25 22:49:05 UTC
[GitHub] [commons-io] jsoref opened a new pull request, #468: Spelling
jsoref opened a new pull request, #468:
URL: https://github.com/apache/commons-io/pull/468
https://issues.apache.org/jira/browse/IO-806
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling).
The misspellings have been reported at https://github.com/jsoref/commons-io/actions/runs/5662536320#summary-15342653080
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/commons-io/actions/runs/5662536436
---
I can fix the summaries to match the requested style, but at the moment I'm all out of available jobs and I'm waiting for the current jobs to finish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #468:
URL: https://github.com/apache/commons-io/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274202266
##########
src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java:
##########
@@ -410,11 +410,11 @@ public void test_reset_Exception() throws IOException {
@Test
public void test_reset_scenario1() throws IOException {
final byte[] input = "12345678900".getBytes();
- final BufferedInputStream buffis = new BufferedInputStream(new ByteArrayInputStream(input));
- buffis.read();
- buffis.mark(5);
- buffis.skip(5);
- buffis.reset();
+ final BufferedInputStream bufin = new BufferedInputStream(new ByteArrayInputStream(input));
+ bufin.read();
+ bufin.mark(5);
+ bufin.skip(5);
+ bufin.reset();
Review Comment:
This file has a whole bunch of different local variables used for `new BufferedInputStream(...)`. There does not appear to be a remotely good reason for so many different ways to spell the same variable name in a single file, but only this one bothered me enough to change it.
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L94
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L112
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L143
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L162
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L172
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L216
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L230
-- this is in the same scope as the previous one, but the previous one is effectively dead, so there's no reason not to recycle it as the next two sites do...
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L281
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L302
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L347
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L390
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L428
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L441
https://github.com/apache/commons-io/blob/318645fd97d6c31cfbce6f5a7fa83d5350e87708/src/test/java/org/apache/commons/io/input/UnsynchronizedBufferedInputStreamTest.java#L461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274650739
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Err... this is a PR, you edit the files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] codecov-commenter commented on pull request #468: Spelling
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #468:
URL: https://github.com/apache/commons-io/pull/468#issuecomment-1650675326
## [Codecov](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#468](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (318645f) into [master](https://app.codecov.io/gh/apache/commons-io/commit/c511d15294d1a406a177368804014313948e2601?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c511d15) will **decrease** coverage by `0.07%`.
> Report is 3 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #468 +/- ##
============================================
- Coverage 84.85% 84.79% -0.07%
+ Complexity 3367 3364 -3
============================================
Files 227 227
Lines 8076 8076
Branches 953 953
============================================
- Hits 6853 6848 -5
- Misses 971 974 +3
- Partials 252 254 +2
```
| [Files Changed](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rc/main/java/org/apache/commons/io/FileSystem.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vRmlsZVN5c3RlbS5qYXZh) | `57.47% <ø> (ø)` | |
| [...apache/commons/io/build/AbstractStreamBuilder.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vYnVpbGQvQWJzdHJhY3RTdHJlYW1CdWlsZGVyLmphdmE=) | `87.17% <ø> (ø)` | |
| [.../org/apache/commons/io/input/QueueInputStream.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vaW5wdXQvUXVldWVJbnB1dFN0cmVhbS5qYXZh) | `100.00% <ø> (ø)` | |
| [...g/apache/commons/io/input/TimestampedObserver.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vaW5wdXQvVGltZXN0YW1wZWRPYnNlcnZlci5qYXZh) | `100.00% <ø> (ø)` | |
| [.../apache/commons/io/output/ChunkedOutputStream.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vb3V0cHV0L0NodW5rZWRPdXRwdXRTdHJlYW0uamF2YQ==) | `100.00% <ø> (ø)` | |
| [...a/org/apache/commons/io/input/XmlStreamReader.java](https://app.codecov.io/gh/apache/commons-io/pull/468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vaW5wdXQvWG1sU3RyZWFtUmVhZGVyLmphdmE=) | `92.00% <100.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/commons-io/pull/468/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274896285
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
It is not. Local vars should be "nonexistentFoo" -> "nonExistentFoo".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1275094029
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
ok, I think this addresses your request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274228815
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Let's not change this please, this is not a spelling error, both spellings are acceptable, one is clearer due to the hyphen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274650739
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Err... this is a PR, you edit the files? Use the hyphenated variant in comments and camel-case in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274263232
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
I've dropped those changes, but I've thrown in some more `existant` -> `existent` changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274249061
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Sure, but do note that you're already using it in [src/main/java/org/apache/commons/io/FileUtils.java](https://github.com/apache/commons-io/blob/06fde31494c279ad940149e1a3d4944040c73c0d/src/main/java/org/apache/commons/io/FileUtils.java#L1091) per https://github.com/search?q=repo%3Aapache%2Fcommons-io%20nonexistent&type=code
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Sure, but do note that you're already using it in [src/main/java/org/apache/commons/io/FileUtils.java](https://github.com/apache/commons-io/blob/06fde31494c279ad940149e1a3d4944040c73c0d/src/main/java/org/apache/commons/io/FileUtils.java#L1091) per https://github.com/search?q=repo%3Aapache%2Fcommons-io%20nonexistent&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a diff in pull request #468: Spelling
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274266890
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Thank you. I'd rather normalize that word on the hyphenated variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274370960
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Sorry, how would you do that? consider https://github.com/apache/commons-io/compare/318645fd97d6c31cfbce6f5a7fa83d5350e87708..810cf30344db9d3e5fffc8ea074d50fae136e558
https://github.com/apache/commons-io/blob/810cf30344db9d3e5fffc8ea074d50fae136e558/src/test/java/org/apache/commons/io/file/PathUtilsTest.java#L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] jsoref commented on a diff in pull request #468: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #468:
URL: https://github.com/apache/commons-io/pull/468#discussion_r1274876430
##########
src/test/java/org/apache/commons/io/file/PathUtilsContentEqualsTest.java:
##########
@@ -44,7 +44,7 @@ private String getName() {
@Test
public void testDirectoryAndFileContentEquals() throws Exception {
- // Non-existent files
+ // Nonexistent files
Review Comment:
Then I think this PR has what you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org