You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2013/12/13 21:05:55 UTC
Review Request 16251: OOZIE-1641 oozie-audit.log - add remote IP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16251/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1641
https://issues.apache.org/jira/browse/OOZIE-1641
Repository: oozie
Description
-------
oozie-audit.log - add remote IP.
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 1550793
Diff: https://reviews.apache.org/r/16251/diff/
Testing
-------
No Testcase.. But tested locally.
[0000000-131213115425271-oozie-puru-W], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null], IP [.......]
Thanks,
Purshotam Shah
Re: Review Request 16251: OOZIE-1641 oozie-audit.log - add remote IP.
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16251/#review30482
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Dec. 16, 2013, 7:47 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16251/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 7:47 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1641
> https://issues.apache.org/jira/browse/OOZIE-1641
>
>
> Repository: oozie
>
>
> Description
> -------
>
> oozie-audit.log - add remote IP.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 1550793
>
> Diff: https://reviews.apache.org/r/16251/diff/
>
>
> Testing
> -------
>
> No Testcase.. But tested locally.
>
> [0000000-131213115425271-oozie-puru-W], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null], IP [.......]
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16251: OOZIE-1641 oozie-audit.log - add remote IP.
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16251/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 7:47 p.m.)
Review request for oozie.
Changes
-------
review comment.
Bugs: OOZIE-1641
https://issues.apache.org/jira/browse/OOZIE-1641
Repository: oozie
Description
-------
oozie-audit.log - add remote IP.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 1550793
Diff: https://reviews.apache.org/r/16251/diff/
Testing
-------
No Testcase.. But tested locally.
[0000000-131213115425271-oozie-puru-W], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null], IP [.......]
Thanks,
Purshotam Shah
Re: Review Request 16251: OOZIE-1641 oozie-audit.log - add remote IP.
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16251/#review30430
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java
<https://reviews.apache.org/r/16251/#comment58219>
Can you log the IP address first instead of last? It will be more intuitive and similar to apache access logs.
- Rohini Palaniswamy
On Dec. 13, 2013, 8:05 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16251/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 8:05 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1641
> https://issues.apache.org/jira/browse/OOZIE-1641
>
>
> Repository: oozie
>
>
> Description
> -------
>
> oozie-audit.log - add remote IP.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 1550793
>
> Diff: https://reviews.apache.org/r/16251/diff/
>
>
> Testing
> -------
>
> No Testcase.. But tested locally.
>
> [0000000-131213115425271-oozie-puru-W], OPERATION [start], PARAMETER [null], STATUS [SUCCESS], HTTPCODE [200], ERRORCODE [null], ERRORMESSAGE [null], IP [.......]
>
>
> Thanks,
>
> Purshotam Shah
>
>