Re: svn commit: r23346 - trunk/subversion/libsvn_wc

[Peter Lundblad <pl...@google.com>]

Malcolm Rowe writes:
> Hi Peter,
> 
> > @@ -449,8 +458,11 @@
> >                                               real_prop_base, pool));
> >          }
> >        else
> > -        SVN_ERR(svn_wc__loggy_remove(log_accum, adm_access, real_prop_base,
> > -                                     pool));
> > +        {
> > +          if (! has_propcaching || (entry && ! entry->has_props))
> > +            SVN_ERR(svn_wc__loggy_remove(log_accum, adm_access, real_prop_base,
> > +                                         pool));
> > +        }
> 
> In this case we've no BASE props to write out, so we don't need the
> BASE property file.  Again, we remove the file if the wc didn't have
> propcaching, but this time we also remove the file if the entry _didn't_
> previously have any properties (and now still doesn't).
> 
That's a thinko of mine.  Thanks for the careeful review!
Fix committed in r23378.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org