[jira] [Commented] (HADOOP-10868) Create a ZooKeeper-backed secret provider

["Alejandro Abdelnur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120551#comment-14120551 ] 

Alejandro Abdelnur commented on HADOOP-10868:
---------------------------------------------

*AuthenticationFilter.java*:

* typo in javadoc 'imeplementation'
* {{ZOOKEEPER_SIGNER_SECRET_PROVIDER_ATTRIBUTE}} constant should have CURATOR in its name, else it is not clear.

*JaasConfiguration.java*:

* class should be annotated as {{@InterfaceAudience.Private}}

*ZKSignerSecretProvider.java*:

* {{createCuratorClient()}}, I don’t like the usage of System properties to set up context, this is not entirely safe. Is there a way to pass all config to the builder via methods?

* The JaasConfiguration and things. If you are logged in using a UGI.loginFromKeytab() and do a ugi.doAs(), can you get rid of all this?

> Create a ZooKeeper-backed secret provider
> -----------------------------------------
>
>                 Key: HADOOP-10868
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10868
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: HADOOP-10868.patch, HADOOP-10868.patch, HADOOP-10868_branch-2.patch, HADOOP-10868_branch-2.patch
>
>
> Create a secret provider (see HADOOP-10791) that is backed by ZooKeeper and can synchronize amongst different servers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)