You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by David Capwell <dc...@gmail.com> on 2020/09/01 18:27:34 UTC
[DISCUSS] Change style guide to recommend use of @Override
Currently our style guide recommends to avoid using @Override and updates
intellij's code style to exclude it by default; I would like to propose we
change this recommendation to use it and to update intellij's style to
include it by default.
@Override is used by javac to enforce that a method is in fact overriding
from an abstract class or an interface and if this stops being true (such
as a refactor happens) then a compiler error is thrown; when we default to
excluding, it makes it harder to detect that a refactor catches all
implementations and can lead to subtle and hard to track down bugs.
This proposal is for new code and would not be to go rewrite all code at
once, but would recommend new code adopt this style, and to pull old code
forward which is related to changes being made (similar to our stance on
imports).
If people are ok with this, I will file a JIRA, update the docs, and
update intellij's formatting.
Thanks for your time!
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by David Capwell <dc...@gmail.com>.
Thanks all! Sent a patch out in
https://issues.apache.org/jira/browse/CASSANDRA-16096 and tested the change
autogenerates the annotation now (if using Intellij it is best to delete
the project and regenerate it as the change didn't take without deleting in
intellij).
On Wed, Sep 2, 2020 at 10:22 AM Blake Eggleston
<be...@apple.com.invalid> wrote:
> +1
>
> > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
> >
> > Currently our style guide recommends to avoid using @Override and updates
> > intellij's code style to exclude it by default; I would like to propose
> we
> > change this recommendation to use it and to update intellij's style to
> > include it by default.
> >
> > @Override is used by javac to enforce that a method is in fact overriding
> > from an abstract class or an interface and if this stops being true (such
> > as a refactor happens) then a compiler error is thrown; when we default
> to
> > excluding, it makes it harder to detect that a refactor catches all
> > implementations and can lead to subtle and hard to track down bugs.
> >
> > This proposal is for new code and would not be to go rewrite all code at
> > once, but would recommend new code adopt this style, and to pull old code
> > forward which is related to changes being made (similar to our stance on
> > imports).
> >
> > If people are ok with this, I will file a JIRA, update the docs, and
> > update intellij's formatting.
> >
> > Thanks for your time!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Blake Eggleston <be...@apple.com.INVALID>.
+1
> On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
>
> Currently our style guide recommends to avoid using @Override and updates
> intellij's code style to exclude it by default; I would like to propose we
> change this recommendation to use it and to update intellij's style to
> include it by default.
>
> @Override is used by javac to enforce that a method is in fact overriding
> from an abstract class or an interface and if this stops being true (such
> as a refactor happens) then a compiler error is thrown; when we default to
> excluding, it makes it harder to detect that a refactor catches all
> implementations and can lead to subtle and hard to track down bugs.
>
> This proposal is for new code and would not be to go rewrite all code at
> once, but would recommend new code adopt this style, and to pull old code
> forward which is related to changes being made (similar to our stance on
> imports).
>
> If people are ok with this, I will file a JIRA, update the docs, and
> update intellij's formatting.
>
> Thanks for your time!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Aleksey Yeshchenko <al...@apple.com.INVALID>.
+1. Some of us have already adopted this change some time ago, but it’d be nice to make it official for everybody.
> On 1 Sep 2020, at 19:27, David Capwell <dc...@gmail.com> wrote:
>
> Currently our style guide recommends to avoid using @Override and updates
> intellij's code style to exclude it by default; I would like to propose we
> change this recommendation to use it and to update intellij's style to
> include it by default.
>
> @Override is used by javac to enforce that a method is in fact overriding
> from an abstract class or an interface and if this stops being true (such
> as a refactor happens) then a compiler error is thrown; when we default to
> excluding, it makes it harder to detect that a refactor catches all
> implementations and can lead to subtle and hard to track down bugs.
>
> This proposal is for new code and would not be to go rewrite all code at
> once, but would recommend new code adopt this style, and to pull old code
> forward which is related to changes being made (similar to our stance on
> imports).
>
> If people are ok with this, I will file a JIRA, update the docs, and
> update intellij's formatting.
>
> Thanks for your time!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Yifan Cai <yc...@gmail.com>.
+1
________________________________
From: Caleb Rackliffe <ca...@gmail.com>
Sent: Tuesday, September 1, 2020 12:08:50 PM
To: dev@cassandra.apache.org <de...@cassandra.apache.org>
Subject: Re: [DISCUSS] Change style guide to recommend use of @Override
+1
On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <ja...@gmail.com>
wrote:
> +1
>
> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org> wrote:
>
> > +1
> >
> > > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
> > >
> > > Currently our style guide recommends to avoid using @Override and
> updates
> > > intellij's code style to exclude it by default; I would like to propose
> > we
> > > change this recommendation to use it and to update intellij's style to
> > > include it by default.
> > >
> > > @Override is used by javac to enforce that a method is in fact
> overriding
> > > from an abstract class or an interface and if this stops being true
> (such
> > > as a refactor happens) then a compiler error is thrown; when we default
> > to
> > > excluding, it makes it harder to detect that a refactor catches all
> > > implementations and can lead to subtle and hard to track down bugs.
> > >
> > > This proposal is for new code and would not be to go rewrite all code
> at
> > > once, but would recommend new code adopt this style, and to pull old
> code
> > > forward which is related to changes being made (similar to our stance
> on
> > > imports).
> > >
> > > If people are ok with this, I will file a JIRA, update the docs, and
> > > update intellij's formatting.
> > >
> > > Thanks for your time!
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> > For additional commands, e-mail: dev-help@cassandra.apache.org
> >
> >
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Robert Stupp <sn...@snazy.de>.
+1
—
Robert Stupp
@snazy
> On 2. Sep 2020, at 10:38, Sylvain Lebresne <le...@gmail.com> wrote:
>
> +1
> --
> Sylvain
>
>
> On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe <sa...@beobal.com> wrote:
>
>> +1
>>
>>> On 2 Sep 2020, at 09:03, Benjamin Lerer <be...@datastax.com>
>> wrote:
>>>
>>> +1
>>>
>>>
>>>
>>> On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi <berenguerblasi@gmail.com
>>>
>>> wrote:
>>>
>>>> +1
>>>>
>>>> On 2/9/20 5:09, Joshua McKenzie wrote:
>>>>> +1
>>>>>
>>>>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
>>>>>> benedict@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
>>>>>>> jasonstack.zhao@gmail.com>
>>>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> +1
>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
>>>>>> wrote:
>>>>>>>>
>>>>>>>
>>>>>>>>> +1
>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>>>> On Sep 1, 2020, at 11:27 AM, David Capwell <
>>>> dcapwell@gmail.com
>>>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>> Currently our style guide recommends to avoid using @Override
>>>>>> and
>>>>>>>> updates
>>>>>>>
>>>>>>>>>> intellij's code style to exclude it by default; I would like
>>>> to
>>>>>>> propose
>>>>>>>
>>>>>>>>> we
>>>>>>>
>>>>>>>>>> change this recommendation to use it and to update intellij's
>>>>>>> style to
>>>>>>>
>>>>>>>>>> include it by default.
>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>> @Override is used by javac to enforce that a method is in
>>>> fact
>>>>>>>
>>>>>>>> overriding
>>>>>>>
>>>>>>>>>> from an abstract class or an interface and if this stops
>>>> being
>>>>>>> true
>>>>>>>
>>>>>>>> (such
>>>>>>>
>>>>>>>>>> as a refactor happens) then a compiler error is thrown; when
>>>> we
>>>>>>> default
>>>>>>>
>>>>>>>>> to
>>>>>>>
>>>>>>>>>> excluding, it makes it harder to detect that a refactor
>>>> catches
>>>>>>> all
>>>>>>>
>>>>>>>>>> implementations and can lead to subtle and hard to track down
>>>>>>> bugs.
>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>> This proposal is for new code and would not be to go rewrite
>>>>>> all
>>>>>>> code
>>>>>>>
>>>>>>>> at
>>>>>>>
>>>>>>>>>> once, but would recommend new code adopt this style, and to
>>>>>> pull
>>>>>>> old
>>>>>>>
>>>>>>>> code
>>>>>>>
>>>>>>>>>> forward which is related to changes being made (similar to
>>>> our
>>>>>>> stance
>>>>>>>
>>>>>>>> on
>>>>>>>
>>>>>>>>>> imports).
>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>> If people are ok with this, I will file a JIRA, update the
>>>>>> docs,
>>>>>>> and
>>>>>>>
>>>>>>>>>> update intellij's formatting.
>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>> Thanks for your time!
>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>>>>
>>>>>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>>>>
>>>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>
>>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Sylvain Lebresne <le...@gmail.com>.
+1
--
Sylvain
On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe <sa...@beobal.com> wrote:
> +1
>
> > On 2 Sep 2020, at 09:03, Benjamin Lerer <be...@datastax.com>
> wrote:
> >
> > +1
> >
> >
> >
> > On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi <berenguerblasi@gmail.com
> >
> > wrote:
> >
> >> +1
> >>
> >> On 2/9/20 5:09, Joshua McKenzie wrote:
> >>> +1
> >>>
> >>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
> >>>
> >>>> +1
> >>>>
> >>>> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
> >>>> benedict@apache.org>
> >>>> wrote:
> >>>>
> >>>>> +1
> >>>>>
> >>>>>
> >>>>>
> >>>>> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>>
> >>>>> +1
> >>>>>
> >>>>>
> >>>>>
> >>>>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
> >>>>> jasonstack.zhao@gmail.com>
> >>>>>
> >>>>> wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> +1
> >>>>>
> >>>>>>
> >>>>>
> >>>>>> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
> >>>> wrote:
> >>>>>>
> >>>>>
> >>>>>>> +1
> >>>>>
> >>>>>>>
> >>>>>
> >>>>>>>> On Sep 1, 2020, at 11:27 AM, David Capwell <
> >> dcapwell@gmail.com
> >>>>>
> >>>>> wrote:
> >>>>>
> >>>>>>>>
> >>>>>
> >>>>>>>> Currently our style guide recommends to avoid using @Override
> >>>> and
> >>>>>> updates
> >>>>>
> >>>>>>>> intellij's code style to exclude it by default; I would like
> >> to
> >>>>> propose
> >>>>>
> >>>>>>> we
> >>>>>
> >>>>>>>> change this recommendation to use it and to update intellij's
> >>>>> style to
> >>>>>
> >>>>>>>> include it by default.
> >>>>>
> >>>>>>>>
> >>>>>
> >>>>>>>> @Override is used by javac to enforce that a method is in
> >> fact
> >>>>>
> >>>>>> overriding
> >>>>>
> >>>>>>>> from an abstract class or an interface and if this stops
> >> being
> >>>>> true
> >>>>>
> >>>>>> (such
> >>>>>
> >>>>>>>> as a refactor happens) then a compiler error is thrown; when
> >> we
> >>>>> default
> >>>>>
> >>>>>>> to
> >>>>>
> >>>>>>>> excluding, it makes it harder to detect that a refactor
> >> catches
> >>>>> all
> >>>>>
> >>>>>>>> implementations and can lead to subtle and hard to track down
> >>>>> bugs.
> >>>>>
> >>>>>>>>
> >>>>>
> >>>>>>>> This proposal is for new code and would not be to go rewrite
> >>>> all
> >>>>> code
> >>>>>
> >>>>>> at
> >>>>>
> >>>>>>>> once, but would recommend new code adopt this style, and to
> >>>> pull
> >>>>> old
> >>>>>
> >>>>>> code
> >>>>>
> >>>>>>>> forward which is related to changes being made (similar to
> >> our
> >>>>> stance
> >>>>>
> >>>>>> on
> >>>>>
> >>>>>>>> imports).
> >>>>>
> >>>>>>>>
> >>>>>
> >>>>>>>> If people are ok with this, I will file a JIRA, update the
> >>>> docs,
> >>>>> and
> >>>>>
> >>>>>>>> update intellij's formatting.
> >>>>>
> >>>>>>>>
> >>>>>
> >>>>>>>> Thanks for your time!
> >>>>>
> >>>>>>>
> >>>>>
> >>>>>>>
> >>>>>
> >>>>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>>
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >>>>>
> >>>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
> >>>>>
> >>>>>>>
> >>>>>
> >>>>>>>
> >>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>>
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >>>>>
> >>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >> For additional commands, e-mail: dev-help@cassandra.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Sam Tunnicliffe <sa...@beobal.com>.
+1
> On 2 Sep 2020, at 09:03, Benjamin Lerer <be...@datastax.com> wrote:
>
> +1
>
>
>
> On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi <be...@gmail.com>
> wrote:
>
>> +1
>>
>> On 2/9/20 5:09, Joshua McKenzie wrote:
>>> +1
>>>
>>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
>>>
>>>> +1
>>>>
>>>> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
>>>> benedict@apache.org>
>>>> wrote:
>>>>
>>>>> +1
>>>>>
>>>>>
>>>>>
>>>>> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
>>>>> jasonstack.zhao@gmail.com>
>>>>>
>>>>> wrote:
>>>>>
>>>>>
>>>>>
>>>>>> +1
>>>>>
>>>>>>
>>>>>
>>>>>> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
>>>> wrote:
>>>>>>
>>>>>
>>>>>>> +1
>>>>>
>>>>>>>
>>>>>
>>>>>>>> On Sep 1, 2020, at 11:27 AM, David Capwell <
>> dcapwell@gmail.com
>>>>>
>>>>> wrote:
>>>>>
>>>>>>>>
>>>>>
>>>>>>>> Currently our style guide recommends to avoid using @Override
>>>> and
>>>>>> updates
>>>>>
>>>>>>>> intellij's code style to exclude it by default; I would like
>> to
>>>>> propose
>>>>>
>>>>>>> we
>>>>>
>>>>>>>> change this recommendation to use it and to update intellij's
>>>>> style to
>>>>>
>>>>>>>> include it by default.
>>>>>
>>>>>>>>
>>>>>
>>>>>>>> @Override is used by javac to enforce that a method is in
>> fact
>>>>>
>>>>>> overriding
>>>>>
>>>>>>>> from an abstract class or an interface and if this stops
>> being
>>>>> true
>>>>>
>>>>>> (such
>>>>>
>>>>>>>> as a refactor happens) then a compiler error is thrown; when
>> we
>>>>> default
>>>>>
>>>>>>> to
>>>>>
>>>>>>>> excluding, it makes it harder to detect that a refactor
>> catches
>>>>> all
>>>>>
>>>>>>>> implementations and can lead to subtle and hard to track down
>>>>> bugs.
>>>>>
>>>>>>>>
>>>>>
>>>>>>>> This proposal is for new code and would not be to go rewrite
>>>> all
>>>>> code
>>>>>
>>>>>> at
>>>>>
>>>>>>>> once, but would recommend new code adopt this style, and to
>>>> pull
>>>>> old
>>>>>
>>>>>> code
>>>>>
>>>>>>>> forward which is related to changes being made (similar to
>> our
>>>>> stance
>>>>>
>>>>>> on
>>>>>
>>>>>>>> imports).
>>>>>
>>>>>>>>
>>>>>
>>>>>>>> If people are ok with this, I will file a JIRA, update the
>>>> docs,
>>>>> and
>>>>>
>>>>>>>> update intellij's formatting.
>>>>>
>>>>>>>>
>>>>>
>>>>>>>> Thanks for your time!
>>>>>
>>>>>>>
>>>>>
>>>>>>>
>>>>>
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>>
>>>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>>
>>>>>>>
>>>>>
>>>>>>>
>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>
>>>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>>>
>>>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Benjamin Lerer <be...@datastax.com>.
+1
On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi <be...@gmail.com>
wrote:
> +1
>
> On 2/9/20 5:09, Joshua McKenzie wrote:
> > +1
> >
> > On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
> >
> >> +1
> >>
> >> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
> >> benedict@apache.org>
> >> wrote:
> >>
> >>> +1
> >>>
> >>>
> >>>
> >>> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
> >> wrote:
> >>>
> >>>
> >>> +1
> >>>
> >>>
> >>>
> >>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
> >>> jasonstack.zhao@gmail.com>
> >>>
> >>> wrote:
> >>>
> >>>
> >>>
> >>> > +1
> >>>
> >>> >
> >>>
> >>> > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
> >> wrote:
> >>> >
> >>>
> >>> > > +1
> >>>
> >>> > >
> >>>
> >>> > > > On Sep 1, 2020, at 11:27 AM, David Capwell <
> dcapwell@gmail.com
> >>>
> >>> wrote:
> >>>
> >>> > > >
> >>>
> >>> > > > Currently our style guide recommends to avoid using @Override
> >> and
> >>> > updates
> >>>
> >>> > > > intellij's code style to exclude it by default; I would like
> to
> >>> propose
> >>>
> >>> > > we
> >>>
> >>> > > > change this recommendation to use it and to update intellij's
> >>> style to
> >>>
> >>> > > > include it by default.
> >>>
> >>> > > >
> >>>
> >>> > > > @Override is used by javac to enforce that a method is in
> fact
> >>>
> >>> > overriding
> >>>
> >>> > > > from an abstract class or an interface and if this stops
> being
> >>> true
> >>>
> >>> > (such
> >>>
> >>> > > > as a refactor happens) then a compiler error is thrown; when
> we
> >>> default
> >>>
> >>> > > to
> >>>
> >>> > > > excluding, it makes it harder to detect that a refactor
> catches
> >>> all
> >>>
> >>> > > > implementations and can lead to subtle and hard to track down
> >>> bugs.
> >>>
> >>> > > >
> >>>
> >>> > > > This proposal is for new code and would not be to go rewrite
> >> all
> >>> code
> >>>
> >>> > at
> >>>
> >>> > > > once, but would recommend new code adopt this style, and to
> >> pull
> >>> old
> >>>
> >>> > code
> >>>
> >>> > > > forward which is related to changes being made (similar to
> our
> >>> stance
> >>>
> >>> > on
> >>>
> >>> > > > imports).
> >>>
> >>> > > >
> >>>
> >>> > > > If people are ok with this, I will file a JIRA, update the
> >> docs,
> >>> and
> >>>
> >>> > > > update intellij's formatting.
> >>>
> >>> > > >
> >>>
> >>> > > > Thanks for your time!
> >>>
> >>> > >
> >>>
> >>> > >
> >>>
> >>> > >
> >>> ---------------------------------------------------------------------
> >>>
> >>> > > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >>>
> >>> > > For additional commands, e-mail: dev-help@cassandra.apache.org
> >>>
> >>> > >
> >>>
> >>> > >
> >>>
> >>> >
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>>
> >>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >>>
> >>> For additional commands, e-mail: dev-help@cassandra.apache.org
> >>>
> >>>
> >>>
> >>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Berenguer Blasi <be...@gmail.com>.
+1
On 2/9/20 5:09, Joshua McKenzie wrote:
> +1
>
> On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
>
>> +1
>>
>> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
>> benedict@apache.org>
>> wrote:
>>
>>> +1
>>>
>>>
>>>
>>> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
>> wrote:
>>>
>>>
>>> +1
>>>
>>>
>>>
>>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
>>> jasonstack.zhao@gmail.com>
>>>
>>> wrote:
>>>
>>>
>>>
>>> > +1
>>>
>>> >
>>>
>>> > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
>> wrote:
>>> >
>>>
>>> > > +1
>>>
>>> > >
>>>
>>> > > > On Sep 1, 2020, at 11:27 AM, David Capwell <dcapwell@gmail.com
>>>
>>> wrote:
>>>
>>> > > >
>>>
>>> > > > Currently our style guide recommends to avoid using @Override
>> and
>>> > updates
>>>
>>> > > > intellij's code style to exclude it by default; I would like to
>>> propose
>>>
>>> > > we
>>>
>>> > > > change this recommendation to use it and to update intellij's
>>> style to
>>>
>>> > > > include it by default.
>>>
>>> > > >
>>>
>>> > > > @Override is used by javac to enforce that a method is in fact
>>>
>>> > overriding
>>>
>>> > > > from an abstract class or an interface and if this stops being
>>> true
>>>
>>> > (such
>>>
>>> > > > as a refactor happens) then a compiler error is thrown; when we
>>> default
>>>
>>> > > to
>>>
>>> > > > excluding, it makes it harder to detect that a refactor catches
>>> all
>>>
>>> > > > implementations and can lead to subtle and hard to track down
>>> bugs.
>>>
>>> > > >
>>>
>>> > > > This proposal is for new code and would not be to go rewrite
>> all
>>> code
>>>
>>> > at
>>>
>>> > > > once, but would recommend new code adopt this style, and to
>> pull
>>> old
>>>
>>> > code
>>>
>>> > > > forward which is related to changes being made (similar to our
>>> stance
>>>
>>> > on
>>>
>>> > > > imports).
>>>
>>> > > >
>>>
>>> > > > If people are ok with this, I will file a JIRA, update the
>> docs,
>>> and
>>>
>>> > > > update intellij's formatting.
>>>
>>> > > >
>>>
>>> > > > Thanks for your time!
>>>
>>> > >
>>>
>>> > >
>>>
>>> > >
>>> ---------------------------------------------------------------------
>>>
>>> > > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>
>>> > > For additional commands, e-mail: dev-help@cassandra.apache.org
>>>
>>> > >
>>>
>>> > >
>>>
>>> >
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>>
>>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>>>
>>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>>
>>>
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Joshua McKenzie <jm...@apache.org>.
+1
On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jo...@gmail.com> wrote:
> +1
>
> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
> benedict@apache.org>
> wrote:
>
> > +1
> >
> >
> >
> > On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com>
> wrote:
> >
> >
> >
> > +1
> >
> >
> >
> > On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
> > jasonstack.zhao@gmail.com>
> >
> > wrote:
> >
> >
> >
> > > +1
> >
> > >
> >
> > > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org>
> wrote:
> >
> > >
> >
> > > > +1
> >
> > > >
> >
> > > > > On Sep 1, 2020, at 11:27 AM, David Capwell <dcapwell@gmail.com
> >
> > wrote:
> >
> > > > >
> >
> > > > > Currently our style guide recommends to avoid using @Override
> and
> >
> > > updates
> >
> > > > > intellij's code style to exclude it by default; I would like to
> > propose
> >
> > > > we
> >
> > > > > change this recommendation to use it and to update intellij's
> > style to
> >
> > > > > include it by default.
> >
> > > > >
> >
> > > > > @Override is used by javac to enforce that a method is in fact
> >
> > > overriding
> >
> > > > > from an abstract class or an interface and if this stops being
> > true
> >
> > > (such
> >
> > > > > as a refactor happens) then a compiler error is thrown; when we
> > default
> >
> > > > to
> >
> > > > > excluding, it makes it harder to detect that a refactor catches
> > all
> >
> > > > > implementations and can lead to subtle and hard to track down
> > bugs.
> >
> > > > >
> >
> > > > > This proposal is for new code and would not be to go rewrite
> all
> > code
> >
> > > at
> >
> > > > > once, but would recommend new code adopt this style, and to
> pull
> > old
> >
> > > code
> >
> > > > > forward which is related to changes being made (similar to our
> > stance
> >
> > > on
> >
> > > > > imports).
> >
> > > > >
> >
> > > > > If people are ok with this, I will file a JIRA, update the
> docs,
> > and
> >
> > > > > update intellij's formatting.
> >
> > > > >
> >
> > > > > Thanks for your time!
> >
> > > >
> >
> > > >
> >
> > > >
> > ---------------------------------------------------------------------
> >
> > > > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >
> > > > For additional commands, e-mail: dev-help@cassandra.apache.org
> >
> > > >
> >
> > > >
> >
> > >
> >
> >
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> >
> > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> >
> > For additional commands, e-mail: dev-help@cassandra.apache.org
> >
> >
> >
> >
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Jordan West <jo...@gmail.com>.
+1
On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <be...@apache.org>
wrote:
> +1
>
>
>
> On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com> wrote:
>
>
>
> +1
>
>
>
> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <
> jasonstack.zhao@gmail.com>
>
> wrote:
>
>
>
> > +1
>
> >
>
> > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org> wrote:
>
> >
>
> > > +1
>
> > >
>
> > > > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com>
> wrote:
>
> > > >
>
> > > > Currently our style guide recommends to avoid using @Override and
>
> > updates
>
> > > > intellij's code style to exclude it by default; I would like to
> propose
>
> > > we
>
> > > > change this recommendation to use it and to update intellij's
> style to
>
> > > > include it by default.
>
> > > >
>
> > > > @Override is used by javac to enforce that a method is in fact
>
> > overriding
>
> > > > from an abstract class or an interface and if this stops being
> true
>
> > (such
>
> > > > as a refactor happens) then a compiler error is thrown; when we
> default
>
> > > to
>
> > > > excluding, it makes it harder to detect that a refactor catches
> all
>
> > > > implementations and can lead to subtle and hard to track down
> bugs.
>
> > > >
>
> > > > This proposal is for new code and would not be to go rewrite all
> code
>
> > at
>
> > > > once, but would recommend new code adopt this style, and to pull
> old
>
> > code
>
> > > > forward which is related to changes being made (similar to our
> stance
>
> > on
>
> > > > imports).
>
> > > >
>
> > > > If people are ok with this, I will file a JIRA, update the docs,
> and
>
> > > > update intellij's formatting.
>
> > > >
>
> > > > Thanks for your time!
>
> > >
>
> > >
>
> > >
> ---------------------------------------------------------------------
>
> > > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>
> > > For additional commands, e-mail: dev-help@cassandra.apache.org
>
> > >
>
> > >
>
> >
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
>
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Benedict Elliott Smith <be...@apache.org>.
+1
On 01/09/2020, 20:09, "Caleb Rackliffe" <ca...@gmail.com> wrote:
+1
On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <ja...@gmail.com>
wrote:
> +1
>
> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org> wrote:
>
> > +1
> >
> > > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
> > >
> > > Currently our style guide recommends to avoid using @Override and
> updates
> > > intellij's code style to exclude it by default; I would like to propose
> > we
> > > change this recommendation to use it and to update intellij's style to
> > > include it by default.
> > >
> > > @Override is used by javac to enforce that a method is in fact
> overriding
> > > from an abstract class or an interface and if this stops being true
> (such
> > > as a refactor happens) then a compiler error is thrown; when we default
> > to
> > > excluding, it makes it harder to detect that a refactor catches all
> > > implementations and can lead to subtle and hard to track down bugs.
> > >
> > > This proposal is for new code and would not be to go rewrite all code
> at
> > > once, but would recommend new code adopt this style, and to pull old
> code
> > > forward which is related to changes being made (similar to our stance
> on
> > > imports).
> > >
> > > If people are ok with this, I will file a JIRA, update the docs, and
> > > update intellij's formatting.
> > >
> > > Thanks for your time!
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> > For additional commands, e-mail: dev-help@cassandra.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Caleb Rackliffe <ca...@gmail.com>.
+1
On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang <ja...@gmail.com>
wrote:
> +1
>
> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org> wrote:
>
> > +1
> >
> > > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
> > >
> > > Currently our style guide recommends to avoid using @Override and
> updates
> > > intellij's code style to exclude it by default; I would like to propose
> > we
> > > change this recommendation to use it and to update intellij's style to
> > > include it by default.
> > >
> > > @Override is used by javac to enforce that a method is in fact
> overriding
> > > from an abstract class or an interface and if this stops being true
> (such
> > > as a refactor happens) then a compiler error is thrown; when we default
> > to
> > > excluding, it makes it harder to detect that a refactor catches all
> > > implementations and can lead to subtle and hard to track down bugs.
> > >
> > > This proposal is for new code and would not be to go rewrite all code
> at
> > > once, but would recommend new code adopt this style, and to pull old
> code
> > > forward which is related to changes being made (similar to our stance
> on
> > > imports).
> > >
> > > If people are ok with this, I will file a JIRA, update the docs, and
> > > update intellij's formatting.
> > >
> > > Thanks for your time!
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> > For additional commands, e-mail: dev-help@cassandra.apache.org
> >
> >
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Jasonstack Zhao Yang <ja...@gmail.com>.
+1
On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <dj...@apache.org> wrote:
> +1
>
> > On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
> >
> > Currently our style guide recommends to avoid using @Override and updates
> > intellij's code style to exclude it by default; I would like to propose
> we
> > change this recommendation to use it and to update intellij's style to
> > include it by default.
> >
> > @Override is used by javac to enforce that a method is in fact overriding
> > from an abstract class or an interface and if this stops being true (such
> > as a refactor happens) then a compiler error is thrown; when we default
> to
> > excluding, it makes it harder to detect that a refactor catches all
> > implementations and can lead to subtle and hard to track down bugs.
> >
> > This proposal is for new code and would not be to go rewrite all code at
> > once, but would recommend new code adopt this style, and to pull old code
> > forward which is related to changes being made (similar to our stance on
> > imports).
> >
> > If people are ok with this, I will file a JIRA, update the docs, and
> > update intellij's formatting.
> >
> > Thanks for your time!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>
Re: [DISCUSS] Change style guide to recommend use of @Override
Posted by Dinesh Joshi <dj...@apache.org>.
+1
> On Sep 1, 2020, at 11:27 AM, David Capwell <dc...@gmail.com> wrote:
>
> Currently our style guide recommends to avoid using @Override and updates
> intellij's code style to exclude it by default; I would like to propose we
> change this recommendation to use it and to update intellij's style to
> include it by default.
>
> @Override is used by javac to enforce that a method is in fact overriding
> from an abstract class or an interface and if this stops being true (such
> as a refactor happens) then a compiler error is thrown; when we default to
> excluding, it makes it harder to detect that a refactor catches all
> implementations and can lead to subtle and hard to track down bugs.
>
> This proposal is for new code and would not be to go rewrite all code at
> once, but would recommend new code adopt this style, and to pull old code
> forward which is related to changes being made (similar to our stance on
> imports).
>
> If people are ok with this, I will file a JIRA, update the docs, and
> update intellij's formatting.
>
> Thanks for your time!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org