You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/05/26 15:09:46 UTC

DO NOT REPLY [Bug 51270] New: [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

             Bug #: 51270
           Summary: [PATCH] PDFOutline: 'endobj' should be preceded by an
                    EOL
           Product: Fop
           Version: all
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: pdf
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: matthias.bauer.drs@infineon.com
    Classification: Unclassified


Created attachment 27071
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27071
patch

org.apache.fop.pdf.PDFOutline.toPDF() outputs ">> endobj\n". 

According to PDF/A spec (or at least according to the validators I've used)
there has to be a "\n" in front of the endobj tag. (And at every other position
in the code we're already outputting a "\n".)

The patch changes the output to ">>\nendobj\n".

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

--- Comment #5 from Glenn Adams <gl...@skynav.com> 2012-04-08 09:10:58 UTC ---
increase priority due to presence of a patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Glenn Adams <gl...@skynav.com> 2012-04-08 20:36:27 UTC ---
the proposed change was commit on 2012-03-21 in r1303431

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

--- Comment #2 from Oliver.Moehrke@web.de 2011-05-31 18:29:08 UTC ---
I applied the patch to the v1.0 source-tree and it solves the compatibility
issue with Intarsys PDF/A Live! validator.

Thank you.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

Andreas L. Delmelle <ad...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Oliver.Moehrke@web.de

--- Comment #1 from Andreas L. Delmelle <ad...@apache.org> 2011-05-31 18:08:08 UTC ---
*** Bug 51301 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

--- Comment #4 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:42:53 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

--- Comment #3 from Andreas L. Delmelle <ad...@apache.org> 2011-05-31 18:34:59 UTC ---

Thanks for reporting, and the patch!
I currently have some conflicting changes to the same classes to work out, and
I'll gladly incorporate this one. 
However, instead of fixing this in one spot --the only place where it happens
to be wrong-- I will, at the same time, look at the other 12 occurrences of
">>\nendobj\n" and extract those into a single method of PDFObject. At least,
that will prevent it from ever reoccurring (assuming that all good devs will
copy the existing pattern, that is)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 51270] [PATCH] PDFOutline: 'endobj' should be preceded by an EOL

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51270

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.