You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/11/01 19:47:21 UTC

svn commit: r1538026 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java

Author: ggregory
Date: Fri Nov  1 18:47:20 2013
New Revision: 1538026

URL: http://svn.apache.org/r1538026
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java?rev=1538026&r1=1538025&r2=1538026&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java Fri Nov  1 18:47:20 2013
@@ -355,9 +355,8 @@ public class PngWriter implements PngCon
         public int getEntry(final int index) {
             if (index == 0) {
                 return 0x00000000;
-            } else {
-                return palette.getEntry(index - 1);
             }
+            return palette.getEntry(index - 1);
         }
         
         @Override
@@ -369,14 +368,12 @@ public class PngWriter implements PngCon
         public int getPaletteIndex(final int rgb) throws ImageWriteException {
             if (rgb == 0x00000000) {
                 return 0;
-            } else {
-                final int index = palette.getPaletteIndex(rgb);
-                if (index >= 0) {
-                    return 1 + index;
-                } else {
-                    return index;
-                }
             }
+            final int index = palette.getPaletteIndex(rgb);
+            if (index >= 0) {
+                return 1 + index;
+            }
+            return index;
         }
     }
     /*