You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/01 20:15:58 UTC

[GitHub] [tvm] areusch opened a new pull request #7388: Jenkinsfile changes for #7333.

areusch opened a new pull request #7388:
URL: https://github.com/apache/tvm/pull/7388


    * Make build/standalone_crt available to CI unit tests.
    * We could do this with stash but it's complex because we would need
      to use wildcards. Instead, rebuild standalone_crt source tree before testing.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7388:
URL: https://github.com/apache/tvm/pull/7388


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#issuecomment-774031525


   @areusch please resolve merge conflict


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on a change in pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#discussion_r568208527



##########
File path: Jenkinsfile
##########
@@ -248,6 +248,8 @@ stage('Unit Test') {
         unpack_lib('gpu', tvm_multilib)
         timeout(time: max_time, unit: 'MINUTES') {
           sh "${docker_run} ${ci_gpu} ./tests/scripts/task_ci_python_setup.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_config_build_gpu.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_build.sh build standalone_crt"

Review comment:
       ok resolved per our discussion. we will not explicitly introduce a separate build step here; instead we will add this build to `tests/scripts/task_ci_setup.sh`, which was previously `tests/scripts/task_ci_python_setup.sh`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on a change in pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#discussion_r568176689



##########
File path: Jenkinsfile
##########
@@ -248,6 +248,8 @@ stage('Unit Test') {
         unpack_lib('gpu', tvm_multilib)
         timeout(time: max_time, unit: 'MINUTES') {
           sh "${docker_run} ${ci_gpu} ./tests/scripts/task_ci_python_setup.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_config_build_gpu.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_build.sh build standalone_crt"

Review comment:
       Would this trigger rebuild of libtvm? or simply just `standalone_crt`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#issuecomment-772127315


   @tqchen good to merge now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on a change in pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#discussion_r568208527



##########
File path: Jenkinsfile
##########
@@ -248,6 +248,8 @@ stage('Unit Test') {
         unpack_lib('gpu', tvm_multilib)
         timeout(time: max_time, unit: 'MINUTES') {
           sh "${docker_run} ${ci_gpu} ./tests/scripts/task_ci_python_setup.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_config_build_gpu.sh"
+          sh "${docker_run} ${ci_gpu} ./tests/scripts/task_build.sh build standalone_crt"

Review comment:
       ok resolved per our discussion. we will not explicitly introduce a separate build step here; instead we will add this build to `tests/scripts/task_ci_setup.sh`, which was previously `tests/scripts/task_ci_python_setup.sh`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7388: Jenkinsfile changes for #7333.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7388:
URL: https://github.com/apache/tvm/pull/7388#issuecomment-775321127


   @tqchen done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org