You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "donnerpeter (via GitHub)" <gi...@apache.org> on 2024/03/04 15:54:07 UTC

[PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

donnerpeter opened a new pull request, #13155:
URL: https://github.com/apache/lucene/pull/13155

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977298245

   > LGTM. A changes.txt entry is missing. Did you mean to assign this to me or just assign me as a reviewer? :)
   
   Oh sorry. I meant you as a reviewer :)
   Is the changes.txt entry needed if I backport this to 9_x (and add the entry there)? AFAIU the changes for 10.0 shouldn't include stuff that's in 9_x? Or am I mistaken?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977361772

   Does it make sense to allow this by default? I don't know how `hunspell` behaves here, but I've seen crazy stuff in these dictionaries...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977369698

   > Does it make sense to allow this by default? I don't know how `hunspell` behaves here, but I've seen crazy stuff in these dictionaries...
   
   @rmuir An interesting idea. Such duplication appears to be a relatively rare condition, not present in the two major dictionary collections I've been testing against. On the other hand, people would need to recompile their code if they find they face such dictionaries. On yet another hand, people might be more motivated to fix the faulty dictionaries. I'm unsure :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977149042

   LGTM. A changes.txt entry is missing. Did you mean to assign this to me or just assign me as a reviewer? :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977321202

   They do go to main with changes under the corresponding 9.x section - then you can typically cherry pick the same commit when backporting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1976938106

   To backport to Lucene 9_x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13155:
URL: https://github.com/apache/lucene/pull/13155#issuecomment-1977322266

   So, on main they'd go somewhere below this place:
   https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

Posted by "donnerpeter (via GitHub)" <gi...@apache.org>.
donnerpeter merged PR #13155:
URL: https://github.com/apache/lucene/pull/13155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org