You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "huaxingao (via GitHub)" <gi...@apache.org> on 2024/11/13 19:06:27 UTC
[PR] assumeThat(format).isEqualTo(parquet) -> assumeThat(format).isEqualTo(FileFormat.PARQUET) [iceberg]
huaxingao opened a new pull request, #11540:
URL: https://github.com/apache/iceberg/pull/11540
With assertj-core-3.26.3.jar, assumeThat(format).isEqualTo("parquet") is failed and the test is silently aborted.
<img width="970" alt="Screenshot 2024-11-13 at 10 09 11 AM" src="https://github.com/user-attachments/assets/2a1caccd-58ac-4cda-9c86-1434bc07cb77">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474655039
> So strange, do you know why it aborts instead of fails?
I think the purpose of `assumeThat` is to determine whether the conditions are suitable for a test to continue. If an assumption fails (e.g., if the file format is not parquet), JUnit will skip the execution of the test case and mark it as ignored rather than failing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474802670
Thanks @amogh-jahagirdar @szehon-ho @Fokko @dramaticlly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] assumeThat(format).isEqualTo(parquet) -> assumeThat(format).isEqualTo(FileFormat.PARQUET) [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474573217
So strange, do you know why it aborts instead of fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474791454
Thanks @huaxingao , and @szehon-ho @Fokko @dramaticlly for reviewing the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #11540:
URL: https://github.com/apache/iceberg/pull/11540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474666252
Ah got it, actually wdyt to change it to assertThat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] assumeThat(format).isEqualTo(parquet) -> assumeThat(format).isEqualTo(FileFormat.PARQUET) [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474580572
Can you fix the pr description like <component>: <short description>?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Use assumeThat(format).isEqualTo(FileFormat.PARQUET) instead of assumeThat(format).isEqualTo(parquet) [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #11540:
URL: https://github.com/apache/iceberg/pull/11540#issuecomment-2474711816
> actually wdyt to change it to assertThat?
In this test suite, the file format could also be [ORC or AVRO](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java#L114). We want to ignore this specific test `testPosDeletesOnParquetFileWithMultipleRowGroups()`
for ORC and AVRO format, that's why we use `assumeThat` instead of `assertThat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org