[GitHub] [maven-javadoc-plugin] bmhm commented on a change in pull request #60: [MJAVADOC-650] - Fix Javadoc search path for Java 9+

[GitBox <gi...@apache.org>]

bmhm commented on a change in pull request #60:
URL: https://github.com/apache/maven-javadoc-plugin/pull/60#discussion_r487734815



##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -3799,7 +3799,7 @@ else if ( SystemUtils.IS_OS_MAC_OSX && !JavaVersion.JAVA_SPECIFICATION_VERSION.i
         {
             javadocExe = new File( SystemUtils.getJavaHome() + File.separator + "bin", javadocCommand );
         }
-        // On Java 9, this has moved to: /usr/lib/jvm/java-9-openjdk-amd64/bin/javadoc
+        // On Java 9 the jre subdirectory was removed from the JDK

Review comment:
       I am not a maintainer, but I think this comment could still go a bit more into details.
   
   "On Java 9 the jre subdirectory was removed from the JDK" does not explain why the relative path from javaHome is different. The interesting part (as explained in the issue) is:
   If the env_var `JAVA_HOME` was not set, and the java binary was called from a JDK installation from the jre subfolder, "java.home" was previously set to `JDK_HOME/jre`. Now as the jre directory disappeared, it is more obvious why this change is necessary.
   
   Maybe a maintainer can tell what should go here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org