You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by voukka <gi...@git.apache.org> on 2015/01/20 16:35:50 UTC
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
GitHub user voukka opened a pull request:
https://github.com/apache/spark/pull/4122
fix for Spark-5335: Destroying cluster in VPC with "--delete-groups" fails to remove security groups
Please see https://issues.apache.org/jira/browse/SPARK-5335.
The fix itself is in e58a8b01a8bedcbfbbc6d04b1c1489255865cf87 commit. Two earlier commits are fixes of another VPC related bug waiting to be merged. I should have created former bug fix in own branch then this fix would not have former fixes. :(
This code is released under the project's license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/voukka/spark SPARK-5335_delete_sg_vpc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4122
----
commit c5ceda308225e90e82d5d3a94685ad30e749069c
Author: Vladimir Grigor <vl...@voukka.com>
Date: 2015-01-14T06:57:59Z
SPARK-5242
commit c3960627c3409575c2772e62b46109fef4f28a52
Author: Vladimir Grigor <vl...@kiosked.com>
Date: 2015-01-14T12:57:27Z
fix for SPARK-5242. Bug bug fix commit: making sure address used resolves
commit e58a8b01a8bedcbfbbc6d04b1c1489255865cf87
Author: Vladimir Grigor <vl...@kiosked.com>
Date: 2015-01-20T15:24:12Z
fix for SPARK-5335: Destroying cluster in VPC with "--delete-groups" fails to remove security groups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74062973
[Test build #27355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27355/consoleFull) for PR 4122 at commit [`730ec05`](https://github.com/apache/spark/commit/730ec05b8a2d53b25971315a164522545f18e78e).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by voukka <gi...@git.apache.org>.
Github user voukka commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74064263
I just rebased my fix and made changes according to review suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-73408670
[Test build #27041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27041/consoleFull) for PR 4122 at commit [`e58a8b0`](https://github.com/apache/spark/commit/e58a8b01a8bedcbfbbc6d04b1c1489255865cf87).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74063071
[Test build #27355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27355/consoleFull) for PR 4122 at commit [`730ec05`](https://github.com/apache/spark/commit/730ec05b8a2d53b25971315a164522545f18e78e).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-73408631
[Test build #27041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27041/consoleFull) for PR 4122 at commit [`e58a8b0`](https://github.com/apache/spark/commit/e58a8b01a8bedcbfbbc6d04b1c1489255865cf87).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74074466
[Test build #27356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27356/consoleFull) for PR 4122 at commit [`090dca9`](https://github.com/apache/spark/commit/090dca95db9d4604799f61e3909e2b2a93c3965e).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74127969
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-73143443
I just ran into this issue. Nice work @voukka on catching this and fixing it.
@voukka To make this easier to merge, could you do the following?
* Rebase this PR so that only this fix in included.
* Link to some reference (like [this](https://forums.aws.amazon.com/thread.jspa?messageID=572559)) in the PR body so that people in the future can understand why this change was made.
* Edit the title to match our convention. Something like: "[SPARK-5335] Fix deletion of security groups within a VPC"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-70673003
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-70971228
I guess review on this can wait until #4038 is merged. You will probably need to rebase this PR at that time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74063074
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27355/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-73408671
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27041/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74074482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27356/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5335] Fix deletion of security groups w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-74064586
[Test build #27356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27356/consoleFull) for PR 4122 at commit [`090dca9`](https://github.com/apache/spark/commit/090dca95db9d4604799f61e3909e2b2a93c3965e).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4122#issuecomment-73408545
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4122#discussion_r24205520
--- Diff: ec2/spark_ec2.py ---
@@ -1082,11 +1109,11 @@ def real_main():
time.sleep(30) # Yes, it does have to be this long :-(
for group in groups:
try:
- conn.delete_security_group(group.name)
- print "Deleted security group " + group.name
+ conn.delete_security_group(group_id=group.id)
+ print "Deleted security group %s, id %s" % (group.name, group.id)
except boto.exception.EC2ResponseError:
success = False
- print "Failed to delete security group " + group.name
+ print "Failed to delete security group %s, id %s" % (group.name, group.id)
--- End diff --
Same here. No need to print the group ID if it's not something the user interacts with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4122#discussion_r24205499
--- Diff: ec2/spark_ec2.py ---
@@ -1082,11 +1109,11 @@ def real_main():
time.sleep(30) # Yes, it does have to be this long :-(
for group in groups:
try:
- conn.delete_security_group(group.name)
- print "Deleted security group " + group.name
+ conn.delete_security_group(group_id=group.id)
+ print "Deleted security group %s, id %s" % (group.name, group.id)
--- End diff --
Is there any place where the user inputs a group by its ID instead of its name? If not, I don't think we should print this here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: fix for Spark-5335: Destroying cluster in VPC ...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4122#discussion_r24206308
--- Diff: ec2/spark_ec2.py ---
@@ -1082,11 +1109,11 @@ def real_main():
time.sleep(30) # Yes, it does have to be this long :-(
for group in groups:
try:
- conn.delete_security_group(group.name)
- print "Deleted security group " + group.name
+ conn.delete_security_group(group_id=group.id)
--- End diff --
I would perhaps add a very short comment saying "we must use the group ID here" so that other developers don't change this back to `group.name` and think it works fine because they are testing outside VPCs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org