[GitHub] [arrow] zeroshade commented on a diff in pull request #34343: GH-34334: [Go][CSV] Support lists and extensions

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34343:
URL: https://github.com/apache/arrow/pull/34343#discussion_r1119001805


##########
go/arrow/csv/reader.go:
##########
@@ -721,6 +734,39 @@ func (r *Reader) parseDecimal256(field array.Builder, str string, prec, scale in
 	field.(*array.Decimal256Builder).Append(val)
 }
 
+func (r *Reader) parseList(field array.Builder, str string) {
+	if r.isNull(str) {
+		field.AppendNull()
+		return
+	}
+	if !(strings.HasPrefix(str, "{") || strings.HasSuffix(str, "}")) {
+		r.err = errors.New("invalid list format. should start with '{' and end with '}'")
+		field.AppendNull()
+		return
+	}
+	str = strings.TrimPrefix(str, "{")
+	str = strings.TrimSuffix(str, "}")
+	strs := strings.Split(str, ",")

Review Comment:
   You probably need to use an actual `csv` reader here instead of just splitting on `","`. The reason is so that quotes are handled properly. Imagine a list of strings where one of the strings has a comma in them. Normal CSV handling would use quotes like `foo,bar,"something,baz"` to handle it. But if you just split on `","` it won't handle the quotes correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org