You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/17 06:03:59 UTC
[GitHub] [pulsar] sundar-10 opened a new pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
sundar-10 opened a new pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-651422847
I think the same fix was already merged in #7272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sundar-10 edited a comment on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
sundar-10 edited a comment on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-648718421
@sijie I am trying to write the test, but there seems to be an import error - org.apache.pulsar.functions.proto.Function which says "cannot resolve symbol Function". This error is present in a few other modules inside pulsar-functions as well. This is hindering me from using the debugger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sundar-10 commented on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
sundar-10 commented on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-650792408
@jiazhai Yeah I am using Intellij idea. I tried what you suggested, I am not able to make it work. Would it be possible to get more detailed steps on resolving this issue? I have sent a private message to you in slack regarding the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sundar-10 commented on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
sundar-10 commented on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-648718421
I am trying to write the test, but there seems to be an import error - org.apache.pulsar.functions.proto.Function which says "cannot resolve symbol Function". This error is present in a few other modules inside pulsar-functions as well. This is hindering me from using the debugger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat closed pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
merlimat closed pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-650655942
@sundar-10 Are you using IntelliJ idea?
If yes, Try this:
```
A better workaround seems to be: Right-click on shard project "component" -> pom.xml in the project view in IntelliJ, choose "Maven" -> "Ignore Projects". Then do a "Maven" -> "Reimport" on the project pom.xml.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sundar-10 commented on pull request #7285: This should be `isBuiltInSink` not `isBuiltInSource` #7271
Posted by GitBox <gi...@apache.org>.
sundar-10 commented on pull request #7285:
URL: https://github.com/apache/pulsar/pull/7285#issuecomment-647014400
@sijie Yeah i will start writing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org