You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/03 07:14:59 UTC
[GitHub] [pulsar] liuzhuang2017 opened a new pull request, #16356: [Fix][docs] Fix the Intellij key nouns.
liuzhuang2017 opened a new pull request, #16356:
URL: https://github.com/apache/pulsar/pull/16356
### Motivation
- I think the Intellij should be changed to IntelliJ IDEA. For details, please refer to the official website https://www.jetbrains.com/idea/ and https://en.wikipedia.org/wiki/IntelliJ_IDEA.
### Modifications
- Modify Intellij to IntelliJ IDEA.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #16356: [Fix][docs] Fix the Intellij key nouns.
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on code in PR #16356:
URL: https://github.com/apache/pulsar/pull/16356#discussion_r912485388
##########
README.md:
##########
@@ -207,7 +207,7 @@ docker push ${image_repo_and_project}/pulsar:$tag
Apache Pulsar is using [lombok](https://projectlombok.org/) so you have to ensure your IDE setup with
required plugins.
-### Intellij
+### IntellJ
Review Comment:
```suggestion
### IntelliJ
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16356: [Fix][docs] Fix the Intellij key nouns.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16356:
URL: https://github.com/apache/pulsar/pull/16356#issuecomment-1173026988
@liuzhuang2017 Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liuzhuang2017 commented on a diff in pull request #16356: [Fix][docs] Fix the Intellij key nouns.
Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on code in PR #16356:
URL: https://github.com/apache/pulsar/pull/16356#discussion_r912490671
##########
README.md:
##########
@@ -207,7 +207,7 @@ docker push ${image_repo_and_project}/pulsar:$tag
Apache Pulsar is using [lombok](https://projectlombok.org/) so you have to ensure your IDE setup with
required plugins.
-### Intellij
+### IntellJ
Review Comment:
@Demogorgon314 , Thanks your review，I will update it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj merged pull request #16356: [Fix][docs] Fix the Intellij key nouns.
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #16356:
URL: https://github.com/apache/pulsar/pull/16356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org