You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/02/27 10:58:21 UTC

[GitHub] rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors

rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors
URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260695609
 
 

 ##########
 File path: hw/drivers/flash/spiflash/src/spiflash.c
 ##########
 @@ -1033,6 +1035,11 @@ spiflash_erase_sector(const struct hal_flash *hal_flash_dev,
     spiflash_cs_deactivate(dev);
 #endif
 
+    /* Usually erase sector takes around 40ms, let's wait here that time.
+     * TODO: Do it configurable per flash.
 
 Review comment:
   because I believe correct fix should be to add defines per all the supported flash and not give it to the user to set. Those values are in the specifications.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services