[jira] [Commented] (TINKERPOP-919) Features needs to specify whether 2 vertex properties with same key/value is allowed.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605980#comment-15605980 ] 

ASF GitHub Bot commented on TINKERPOP-919:
------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/463

    TINKERPOP-919 Added supportsIdenticalMultiProperties()

    https://issues.apache.org/jira/browse/TINKERPOP-919
    
    That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key. Not sure why this wasn't implemented long ago. It was relatively straightforward to put in place. I did take a look at the test suite for existing tests that might have needed this feature included, but I didn't see any.
    
    `mvn clean install -DincludeNeo4j` is all good
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-919

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #463
    
----
commit ead13106981bc019be25b66e0e432741c3646a2f
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-10-25T17:50:48Z

    TINKERPOP-919 Added supportsIdenticalMultiProperties()
    
    That feature allows a graph to specify whether or not it supports multi-properties that allow the same value to be supplied on the same key.

----


> Features needs to specify whether 2 vertex properties with same key/value is allowed.
> -------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-919
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-919
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure, test-suite, tinkergraph
>    Affects Versions: 3.0.2-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: stephen mallette
>
> TinkerGraph does not support two vertex properties with the same key/value.
> {code}
> gremlin> graph = TinkerGraph.open()
> ==>tinkergraph[vertices:0 edges:0]
> gremlin> v = graph.addVertex()
> ==>v[0]
> gremlin> v.property("name","marko")
> ==>vp[name->marko]
> gremlin> v.property("name","marko")
> ==>vp[name->marko]
> gremlin> v.properties("name")
> ==>vp[name->marko]
> {code}
> I just noted we don't have this as a {{Feature}} and we should (w/ respective test cases).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)