You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2012/02/03 23:15:53 UTC

broke the shims (was: svn commit: r1240370 ...)

Hyrum,

Per our discussion, I updated what I could, but not everything (and I
ran no shims tests). Since I completely disabled the calls to
set_props() and set_text(), I know the shims are broken. I don't think
the changes to fix that part will be too hard.

It also looks like I broke some calls to build() by passing PROPS with
an action other than ACTION_PROPSET.

In any case... your turn now :-)

Cheers,
-g

On Fri, Feb 3, 2012 at 17:07,  <gs...@apache.org> wrote:
> Author: gstein
> Date: Fri Feb  3 22:07:31 2012
> New Revision: 1240370
>
> URL: http://svn.apache.org/viewvc?rev=1240370&view=rev
> Log:
> Update the Ev2 API, per recent discussions. This introduces the
> alter_* callbacks to atomically perform all changes to a node (rather
> than the old paired-call approach).
>
> Documentation for the changes is incomplete, for a future revision.
>
> The compatibility shims have not been fully-updated.
>...

Re: broke the shims (was: svn commit: r1240370 ...)

Posted by Hyrum K Wright <hy...@wandisco.com>.
As of r1240597, I think everything is back to functional.  (Only 15
test failures with the shims enabled.)

-Hyrum

On Fri, Feb 3, 2012 at 4:21 PM, Hyrum K Wright
<hy...@wandisco.com> wrote:
> No problem.  I'll take a look at it over the weekend.
>
> -Hyrum
>
> On Fri, Feb 3, 2012 at 4:15 PM, Greg Stein <gs...@gmail.com> wrote:
>> Hyrum,
>>
>> Per our discussion, I updated what I could, but not everything (and I
>> ran no shims tests). Since I completely disabled the calls to
>> set_props() and set_text(), I know the shims are broken. I don't think
>> the changes to fix that part will be too hard.
>>
>> It also looks like I broke some calls to build() by passing PROPS with
>> an action other than ACTION_PROPSET.
>>
>> In any case... your turn now :-)
>>
>> Cheers,
>> -g
>>
>> On Fri, Feb 3, 2012 at 17:07,  <gs...@apache.org> wrote:
>>> Author: gstein
>>> Date: Fri Feb  3 22:07:31 2012
>>> New Revision: 1240370
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1240370&view=rev
>>> Log:
>>> Update the Ev2 API, per recent discussions. This introduces the
>>> alter_* callbacks to atomically perform all changes to a node (rather
>>> than the old paired-call approach).
>>>
>>> Documentation for the changes is incomplete, for a future revision.
>>>
>>> The compatibility shims have not been fully-updated.
>>>...
>
>
>
> --
>
> uberSVN: Apache Subversion Made Easy
> http://www.uberSVN.com/



-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Re: broke the shims (was: svn commit: r1240370 ...)

Posted by Hyrum K Wright <hy...@wandisco.com>.
No problem.  I'll take a look at it over the weekend.

-Hyrum

On Fri, Feb 3, 2012 at 4:15 PM, Greg Stein <gs...@gmail.com> wrote:
> Hyrum,
>
> Per our discussion, I updated what I could, but not everything (and I
> ran no shims tests). Since I completely disabled the calls to
> set_props() and set_text(), I know the shims are broken. I don't think
> the changes to fix that part will be too hard.
>
> It also looks like I broke some calls to build() by passing PROPS with
> an action other than ACTION_PROPSET.
>
> In any case... your turn now :-)
>
> Cheers,
> -g
>
> On Fri, Feb 3, 2012 at 17:07,  <gs...@apache.org> wrote:
>> Author: gstein
>> Date: Fri Feb  3 22:07:31 2012
>> New Revision: 1240370
>>
>> URL: http://svn.apache.org/viewvc?rev=1240370&view=rev
>> Log:
>> Update the Ev2 API, per recent discussions. This introduces the
>> alter_* callbacks to atomically perform all changes to a node (rather
>> than the old paired-call approach).
>>
>> Documentation for the changes is incomplete, for a future revision.
>>
>> The compatibility shims have not been fully-updated.
>>...



-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/