You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/20 19:32:53 UTC
Review Request 19480: Changed review bot trigger to include dependency
changes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
see summary
Diffs
-----
support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
Diff: https://reviews.apache.org/r/19480/diff/
Testing
-------
commented out actions and ran bot locally. checked reviews that would be verified.
Thanks,
Dominic Hamon
Re: Review Request 19480: Changed review bot trigger to include dependency
changes.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On March 20, 2014, 11:49 a.m., Vinod Kone wrote:
> > support/verify-reviews.py, line 170
> > <https://reviews.apache.org/r/19480/diff/1/?file=530387#file530387line170>
> >
> > shouldn't this be reversed list of changes so that you get the timestamp of the latest dependency change?
the changes are already in the correct order (newest change first).
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/#review37942
-----------------------------------------------------------
On March 20, 2014, 11:58 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19480/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 11:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
>
> Diff: https://reviews.apache.org/r/19480/diff/
>
>
> Testing
> -------
>
> commented out actions and ran bot locally. checked reviews that would be verified.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19480: Changed review bot trigger to include dependency
changes.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/#review37942
-----------------------------------------------------------
support/verify-reviews.py
<https://reviews.apache.org/r/19480/#comment69757>
shouldn't this be reversed list of changes so that you get the timestamp of the latest dependency change?
support/verify-reviews.py
<https://reviews.apache.org/r/19480/#comment69762>
This only detects "dependency" changes in this review but not in the dependent reviews right? That would be nice. Maybe a add a TODO for now.
support/verify-reviews.py
<https://reviews.apache.org/r/19480/#comment69758>
Indentation?
- Vinod Kone
On March 20, 2014, 6:32 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19480/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 6:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
>
> Diff: https://reviews.apache.org/r/19480/diff/
>
>
> Testing
> -------
>
> commented out actions and ran bot locally. checked reviews that would be verified.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19480: Changed review bot trigger to include dependency
changes.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/#review38134
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 20, 2014, 6:58 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19480/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 6:58 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
>
> Diff: https://reviews.apache.org/r/19480/diff/
>
>
> Testing
> -------
>
> commented out actions and ran bot locally. checked reviews that would be verified.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19480: Changed review bot trigger to include dependency
changes.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/#review38163
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19480]
All tests passed.
- Mesos ReviewBot
On March 20, 2014, 6:58 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19480/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 6:58 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
>
> Diff: https://reviews.apache.org/r/19480/diff/
>
>
> Testing
> -------
>
> commented out actions and ran bot locally. checked reviews that would be verified.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19480: Changed review bot trigger to include dependency
changes.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19480/
-----------------------------------------------------------
(Updated March 20, 2014, 11:58 a.m.)
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
support/verify-reviews.py 5bfa1a5339f8338e970227ba27c57ee66a5a3d53
Diff: https://reviews.apache.org/r/19480/diff/
Testing
-------
commented out actions and ran bot locally. checked reviews that would be verified.
Thanks,
Dominic Hamon