[GitHub] [spark] maropu commented on a change in pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29904:
URL: https://github.com/apache/spark/pull/29904#discussion_r497557160



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -90,7 +91,8 @@ case class BroadcastExchangeExec(
 
   override def runtimeStatistics: Statistics = {
     val dataSize = metrics("dataSize").value
-    Statistics(dataSize)
+    val numRows = metrics("numRows").value
+    Statistics(dataSize, Some(numRows))

Review comment:
       It seems the PR description says nothing about this update, so could you describe it there?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org