You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/01/24 20:51:22 UTC
[GitHub] necouchman commented on a change in pull request #369:
GUACAMOLE-716: Add all LDAP properties to Docker start script
necouchman commented on a change in pull request #369: GUACAMOLE-716: Add all LDAP properties to Docker start script
URL: https://github.com/apache/guacamole-client/pull/369#discussion_r250771561
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -303,27 +303,29 @@ END
set_property "ldap-hostname" "$LDAP_HOSTNAME"
set_optional_property "ldap-port" "$LDAP_PORT"
set_optional_property "ldap-encryption-method" "$LDAP_ENCRYPTION_METHOD"
+ set_optional_property "ldap-max-search-results" "$LDAP_MAX_SEARCH_RESULTS"
+ set_optional_property "ldap-search-bind-dn" "$LDAP_SEARCH_BIND_DN"
set_property "ldap-user-base-dn" "$LDAP_USER_BASE_DN"
set_optional_property "ldap-username-attribute" "$LDAP_USERNAME_ATTRIBUTE"
- set_optional_property "ldap-member-attribute" "$LDAP_MEMBER_ATTRIBUTE"
- set_optional_property "ldap-group-base-dn" "$LDAP_GROUP_BASE_DN"
+ set_optional_property "ldap-user-search-filter" "$LDAP_USER_SEARCH_FILTER"
set_optional_property "ldap-config-base-dn" "$LDAP_CONFIG_BASE_DN"
-
- set_optional_property \
- "ldap-search-bind-dn" \
- "$LDAP_SEARCH_BIND_DN"
Review comment:
I like the reformatting overall, but I'm concerned about these items that reorganize properties away from each other - for example, the `ldap-search-bind-dn` property ends up several lines away from `ldap-search-bind-password`. While this isn't something that users will every see or care about, from a debugging and code maintenance point of view I think it could organized so that it makes a little more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services