You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 23:41:27 UTC

[GitHub] [arrow] projjal commented on a change in pull request #10742: ARROW-13375: [C++][Gandiva] Implement POSITIVE and NEGATIVE Hive functions on Gandiva

projjal commented on a change in pull request #10742:
URL: https://github.com/apache/arrow/pull/10742#discussion_r766237068



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -892,6 +892,28 @@ const char* gdv_fn_aes_decrypt(int64_t context, const char* data, int32_t data_l
 
   return ret;
 }
+
+// Expand inner macro for all integer types.
+#define NEGATIVE_FN_INTEGER_PARAMS(INNER) \

Review comment:
       why not include them in the precompiled code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org