You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by "Guy Allard (JIRA)" <ji...@apache.org> on 2012/10/26 18:45:13 UTC

[jira] [Created] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Guy Allard created APLO-266:
-------------------------------

             Summary: 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
                 Key: APLO-266
                 URL: https://issues.apache.org/jira/browse/APLO-266
             Project: ActiveMQ Apollo
          Issue Type: Bug
          Components: apollo-stomp
         Environment: Ubuntu 11.10
Ruby (various versions)
AMD Phenom(tm) II X6 1055T Processor
16GB RAM
apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
            Reporter: Guy Allard


I am testing Stomp 1.2 functionality that uses CRLF line ends.

Under some conditions, sending a frame with \r\n line ends results in, e.g.:

2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1

This does not happen all the time.

I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Guy Allard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486117#comment-13486117 ] 

Guy Allard commented on APLO-266:
---------------------------------

Thanks Hiram.  Is that fix in:

apache-apollo-99-trunk-20121029.143110-122-unix-distro.tar.gz

??


                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>            Assignee: Hiram Chirino
>             Fix For: 1.5
>
>         Attachments: letest2.rb, letest3.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Guy Allard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485119#comment-13485119 ] 

Guy Allard commented on APLO-266:
---------------------------------

One comment and question.  In that test code, if you uncomment:

p [ "msg", msg ]

and review the results, you will see a MESSAGE read from the wire.  The headers in that message are 'mixed mode'.  In other words some headers have '\n' line ends, some have '\r\n' line ends.

Is that right?  Should I expect that as the general case?

Thanks, Guy

                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>         Attachments: letest2.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485131#comment-13485131 ] 

Hiram Chirino commented on APLO-266:
------------------------------------

Yeah the 'mix mode' is allowed in 1.2.  Specifically what's causing the mixed mode is that message headers that were originally sent /w  CRLF, preserve the CRLF, but new headers which the broker adds to the message only have LF.  Technically that is allowed by the 1.2 spec.  But I do think it would nicer the broker make them more consistent.
                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>         Attachments: letest2.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Guy Allard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guy Allard updated APLO-266:
----------------------------

    Attachment: letest2.rb
    
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>         Attachments: letest2.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486824#comment-13486824 ] 

Hiram Chirino commented on APLO-266:
------------------------------------

Yep that's the one.
                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>            Assignee: Hiram Chirino
>             Fix For: 1.5
>
>         Attachments: letest2.rb, letest3.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved APLO-266.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5
         Assignee: Hiram Chirino

Thanks for the test cases.  I've now applied a fix and it's being deployed in the following CI build:
https://builds.apache.org/job/ActiveMQ-Apollo-Deploy/311/console

I think the CRLF inconsistency should also be resolved now.  Apollo should always delivery messages with just NL headers now.
                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>            Assignee: Hiram Chirino
>             Fix For: 1.5
>
>         Attachments: letest2.rb, letest3.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (APLO-266) 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]

Posted by "Guy Allard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/APLO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guy Allard updated APLO-266:
----------------------------

    Attachment: letest3.rb

This is a significantly shorter example that triggers the described behavior.

                
> 1.2 with CRLF, sometimes gets: IOException: Unable to parse header line [\u0013]
> --------------------------------------------------------------------------------
>
>                 Key: APLO-266
>                 URL: https://issues.apache.org/jira/browse/APLO-266
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-stomp
>         Environment: Ubuntu 11.10
> Ruby (various versions)
> AMD Phenom(tm) II X6 1055T Processor
> 16GB RAM
> apache-apollo-99-trunk-20120929.031419-121-unix-distro.tar.gz
>            Reporter: Guy Allard
>         Attachments: letest2.rb, letest3.rb
>
>
> I am testing Stomp 1.2 functionality that uses CRLF line ends.
> Under some conditions, sending a frame with \r\n line ends results in, e.g.:
> 2012-10-26 12:25:07,258 | WARN  | java.io.IOException: Unable to parse header line [\u0013] | org.apache.activemq.apollo.broker.Broker | hawtdispatch-DEFAULT-1
> This does not happen all the time.
> I do have a somewhat lengthy (but straightforward) program that recreates this.  I will attach it shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira