You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/12/08 09:05:30 UTC

[GitHub] spark pull request #23261: [WIP][SPARK-23674][ML] Adds Spark ML Events

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23261#discussion_r239998855
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
    @@ -210,7 +214,7 @@ abstract class PredictionModel[FeaturesType, M <: PredictionModel[FeaturesType,
         }
       }
     
    -  protected def transformImpl(dataset: Dataset[_]): DataFrame = {
    +  override protected def transformImpl(dataset: Dataset[_]): DataFrame = {
    --- End diff --
    
    For clarification, some of abstraction already has `transformImpl`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org