You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2007/11/03 18:13:25 UTC
changelists
Hi,
According to the API docs for svn_client_add_to_changelist, any path can
be added to a changelist. But it only works for files. Folders are not
added to the changelist, and files inside added folders aren't either.
In both cases, the function svn_client_add_to_changelist doesn't return
an error.
I think the function should either return an error (e.g., 'not
supported') or allow folders to be added to a changelist too (which I
would prefer).
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: changelists
Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
>> Ben Collins-Sussman wrote:
>>> On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> According to the API docs for svn_client_add_to_changelist, any path can
>>>> be added to a changelist. But it only works for files. Folders are not
>>>> added to the changelist, and files inside added folders aren't either.
>>>> In both cases, the function svn_client_add_to_changelist doesn't return
>>>> an error.
>>>>
>>>> I think the function should either return an error (e.g., 'not
>>>> supported') or allow folders to be added to a changelist too (which I
>>>> would prefer).
>>> You're right, the svn_client_* routine should error on non-files for svn 1.5.
>> Does that mean folders can't be part of a changelist? In that case, I
>> have to make a few adjustments in TSVN.
>
> Yes, this came up just before SubConf, there was a thread about it.
> Folders currently introduce some edge cases that the code does not
> handle well. So it was decided to just not allow them until someone
> wants to tackle the issues or perhaps until we have a new centralized
> WC.
Ok, no problem. I just deactivate the menu entry in TSVN for folders then.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: changelists
Posted by Mark Phippard <ma...@gmail.com>.
On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
> Ben Collins-Sussman wrote:
> > On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
> >> Hi,
> >>
> >> According to the API docs for svn_client_add_to_changelist, any path can
> >> be added to a changelist. But it only works for files. Folders are not
> >> added to the changelist, and files inside added folders aren't either.
> >> In both cases, the function svn_client_add_to_changelist doesn't return
> >> an error.
> >>
> >> I think the function should either return an error (e.g., 'not
> >> supported') or allow folders to be added to a changelist too (which I
> >> would prefer).
> >
> > You're right, the svn_client_* routine should error on non-files for svn 1.5.
>
> Does that mean folders can't be part of a changelist? In that case, I
> have to make a few adjustments in TSVN.
Yes, this came up just before SubConf, there was a thread about it.
Folders currently introduce some edge cases that the code does not
handle well. So it was decided to just not allow them until someone
wants to tackle the issues or perhaps until we have a new centralized
WC.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: changelists
Posted by Stefan Küng <to...@gmail.com>.
Ben Collins-Sussman wrote:
> On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
>> Hi,
>>
>> According to the API docs for svn_client_add_to_changelist, any path can
>> be added to a changelist. But it only works for files. Folders are not
>> added to the changelist, and files inside added folders aren't either.
>> In both cases, the function svn_client_add_to_changelist doesn't return
>> an error.
>>
>> I think the function should either return an error (e.g., 'not
>> supported') or allow folders to be added to a changelist too (which I
>> would prefer).
>
> You're right, the svn_client_* routine should error on non-files for svn 1.5.
Does that mean folders can't be part of a changelist? In that case, I
have to make a few adjustments in TSVN.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: changelists
Posted by Ben Collins-Sussman <su...@red-bean.com>.
On 11/3/07, Stefan Küng <to...@gmail.com> wrote:
> Hi,
>
> According to the API docs for svn_client_add_to_changelist, any path can
> be added to a changelist. But it only works for files. Folders are not
> added to the changelist, and files inside added folders aren't either.
> In both cases, the function svn_client_add_to_changelist doesn't return
> an error.
>
> I think the function should either return an error (e.g., 'not
> supported') or allow folders to be added to a changelist too (which I
> would prefer).
You're right, the svn_client_* routine should error on non-files for svn 1.5.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org