You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carlos Pita (JIRA)" <ji...@apache.org> on 2008/03/23 03:03:32 UTC
[jira] Created: (WICKET-1443) Allow to load properties in different
encodings
Allow to load properties in different encodings
-----------------------------------------------
Key: WICKET-1443
URL: https://issues.apache.org/jira/browse/WICKET-1443
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.2
Reporter: Carlos Pita
This is as simple as changing line
properties.load(in);
to
properties.load(new InputStreamReader(in, charSet));
in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1443) Allow to load properties in
different encodings
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581338#action_12581338 ]
Carlos Pita commented on WICKET-1443:
-------------------------------------
Ok, but I thought it was a good idea as far as it's just a matter of changing a couple of lines of code and allow users to set the propertyfactory from resourcesettings.
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
> Fix For: 1.3.3
>
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1443) Allow to load properties in different
encodings
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1443:
---------------------------------------
Fix Version/s: (was: 1.3.3)
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1443) Allow to load properties in
different encodings
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1443.
-----------------------------------
Resolution: Won't Fix
Fix Version/s: 1.3.3
this has been discussed before. if you want a different encoding you should use xml property files which support it natively.
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
> Fix For: 1.3.3
>
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1443) Allow to load properties
in different encodings
Posted by "Olivier Bourgeois (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750933#action_12750933 ]
Olivier Bourgeois edited comment on WICKET-1443 at 9/3/09 2:26 AM:
-------------------------------------------------------------------
I think the solution I propose in WICKET-2451 would be compatible with extensions libraries having other charsets.
was (Author: obourgeois):
I think the solution I propose would be compatible with extensions libraries having other charsets.
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1443) Allow to load properties in
different encodings
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581339#action_12581339 ]
Igor Vaynberg commented on WICKET-1443:
---------------------------------------
what about 3rd party components that come with .properties in a different encoding then the one you set in your application?
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
> Fix For: 1.3.3
>
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1443) Allow to load properties in
different encodings
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1443:
-------------------------------------
Assignee: Igor Vaynberg
> Allow to load properties in different encodings
> -----------------------------------------------
>
> Key: WICKET-1443
> URL: https://issues.apache.org/jira/browse/WICKET-1443
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Carlos Pita
> Assignee: Igor Vaynberg
> Fix For: 1.3.3
>
>
> This is as simple as changing line
> properties.load(in);
> to
> properties.load(new InputStreamReader(in, charSet));
> in PropertiesFactory. By means of extension and overriding is impossible to do something like that currently, without copy-pasting a lot of code,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.