You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/22 06:56:31 UTC
Review Request 66206: Used native protobuf map in Docker v1 image
spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
Bugs: MESOS-8702
https://issues.apache.org/jira/browse/MESOS-8702
Repository: mesos
Description
-------
Used native protobuf map in Docker v1 image spec.
Diffs
-----
include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360
src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3
src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480
Diff: https://reviews.apache.org/r/66206/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66206: Used native protobuf map in Docker v1 image
spec.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/#review200141
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 21, 2018, 11:56 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66206/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 11:56 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in Docker v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
> src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360
> src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3
> src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480
>
>
> Diff: https://reviews.apache.org/r/66206/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66206: Used native protobuf map in Docker v1 image
spec.
Posted by Gilbert Song <so...@gmail.com>.
> On March 22, 2018, 11:39 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/docker/v1.proto
> > Line 67 (original), 57 (patched)
> > <https://reviews.apache.org/r/66206/diff/1/?file=1985220#file1985220line67>
> >
> > Since this is a public proto file, is there any endpoint or API that enables a user to directly use this proto message? If yes, then this seems a breaking change since the user may be providing the following json:
> > ```
> > {
> > "labels": [
> > {
> > "key": "SOME_KEY",
> > "value": "SOME_VALUE"
> > }
> > ]
> > }
> > ```
>
> Qian Zhang wrote:
> It is used to parse the image manifest of the Docker image pulled by Docker image store in UCR, so I do not think the user will use it directly. And based on Docker v1 image spec, the field name is `Labels` rather than `labels` which is just our own workaround in Mesos code, so I think it should not be possible for a Docker image manifest having labels like below:
> ```
> "labels": [
> {
> "key": "SOME_KEY",
> "value": "SOME_VALUE"
> }
> ]
> ```
@Chun, this is not a publi facing API. Should be fine.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/#review199795
-----------------------------------------------------------
On March 21, 2018, 11:56 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66206/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 11:56 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in Docker v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
> src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360
> src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3
> src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480
>
>
> Diff: https://reviews.apache.org/r/66206/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66206: Used native protobuf map in Docker v1 image
spec.
Posted by Qian Zhang <zh...@gmail.com>.
> On March 23, 2018, 2:39 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/docker/v1.proto
> > Line 67 (original), 57 (patched)
> > <https://reviews.apache.org/r/66206/diff/1/?file=1985220#file1985220line67>
> >
> > Since this is a public proto file, is there any endpoint or API that enables a user to directly use this proto message? If yes, then this seems a breaking change since the user may be providing the following json:
> > ```
> > {
> > "labels": [
> > {
> > "key": "SOME_KEY",
> > "value": "SOME_VALUE"
> > }
> > ]
> > }
> > ```
It is used to parse the image manifest of the Docker image pulled by Docker image store in UCR, so I do not think the user will use it directly. And based on Docker v1 image spec, the field name is `Labels` rather than `labels` which is just our own workaround in Mesos code, so I think it should not be possible for a Docker image manifest having labels like below:
```
"labels": [
{
"key": "SOME_KEY",
"value": "SOME_VALUE"
}
]
```
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/#review199795
-----------------------------------------------------------
On March 22, 2018, 2:56 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66206/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 2:56 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in Docker v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
> src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360
> src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3
> src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480
>
>
> Diff: https://reviews.apache.org/r/66206/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 66206: Used native protobuf map in Docker v1 image
spec.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66206/#review199795
-----------------------------------------------------------
include/mesos/docker/v1.proto
Line 67 (original), 57 (patched)
<https://reviews.apache.org/r/66206/#comment280254>
Since this is a public proto file, is there any endpoint or API that enables a user to directly use this proto message? If yes, then this seems a breaking change since the user may be providing the following json:
```
{
"labels": [
{
"key": "SOME_KEY",
"value": "SOME_VALUE"
}
]
}
```
- Chun-Hung Hsiao
On March 22, 2018, 6:56 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66206/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 6:56 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
>
>
> Bugs: MESOS-8702
> https://issues.apache.org/jira/browse/MESOS-8702
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used native protobuf map in Docker v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
> src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360
> src/slave/containerizer/mesos/isolators/gpu/volume.cpp 536a3c711faf3c165bebaaa3c92717737d67b6f3
> src/tests/containerizer/docker_spec_tests.cpp 5fde49a495c2a2fa880e7cb1bae2f636edecd480
>
>
> Diff: https://reviews.apache.org/r/66206/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>