[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #2214:
URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239619567


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##########
@@ -384,12 +375,10 @@ public void testMergeKeysConflict() {
 
         sql("CREATE TABLE test2 (k int PRIMARY KEY, a int, b int)");
 
-        IgniteException ex = assertThrows(IgniteException.class, () -> sql(
-                        "MERGE INTO test2 USING test1 ON test1.a = test2.a "
-                                + "WHEN MATCHED THEN UPDATE SET b = test1.b + 1 "
-                                + "WHEN NOT MATCHED THEN INSERT (k, a, b) VALUES (0, a, b)"));
-
-        assertEquals(Sql.DUPLICATE_KEYS_ERR, ex.code());
+        assertSqlExceptionThrows(Sql.DUPLICATE_KEYS_ERR, () -> sql(

Review Comment:
   ```suggestion
           assertThrowsSqlException(Sql.DUPLICATE_KEYS_ERR, () -> sql(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org