Re: [PR] doc-gen: migrate scalar functions (encoding & regex) documentation [datafusion]

["Chen-Yuan-Lai (via GitHub)" <gi...@apache.org>]

Chen-Yuan-Lai commented on code in PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#discussion_r1901429188


##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -126,10 +124,21 @@ impl ScalarUDFImpl for EncodeFunc {
     }
 
     fn documentation(&self) -> Option<&Documentation> {
-        Some(get_encode_doc())
+        self.doc()
     }
 }
 
+#[user_doc(
+    doc_section(label = "Binary String Functions"),
+    description = "Decode binary data from textual representation in string.",
+    syntax_example = "decode(e xpression, format)",

Review Comment:
   @alamb  thanks for the correction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org