You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/30 14:51:07 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20406: OneDNN unit test file, small tidy up
mozga-intel opened a new pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406
## Description ##
This pull request tidies up a python unit-test file.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20406: OneDNN unit test file, small tidy up
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#discussion_r666049375
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -309,15 +319,18 @@ def check_batchnorm_training(stype):
data = mx.symbol.Variable('data', stype=stype)
in_location = [mx.nd.array(data_tmp).tostype(stype), mx.nd.array(gamma).tostype(stype),
mx.nd.array(beta).tostype(stype)]
- mean_std = [mx.nd.array(rolling_mean).tostype(stype), mx.nd.array(rolling_std).tostype(stype)]
+ mean_std = [mx.nd.array(rolling_mean).tostype(
Review comment:
```suggestion
mean_std = [mx.nd.array(rolling_mean).tostype(stype),
mx.nd.array(rolling_std).tostype(stype)]
```
or
```suggestion
mean_std =
[mx.nd.array(rolling_mean).tostype(stype),
mx.nd.array(rolling_std).tostype(stype)]
```
?
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -405,14 +420,18 @@ def check_pooling_training(stype):
in_location = [mx.nd.array(data_tmp).tostype(stype)]
if np.array(shape).shape[0] == 3:
- test = mx.symbol.Pooling(data=data, kernel=(3), stride=(2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3), stride=(2), pool_type='avg')
elif np.array(shape).shape[0] == 4:
- test = mx.symbol.Pooling(data=data, kernel=(3, 3), stride=(2, 2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3, 3), stride=(2, 2), pool_type='avg')
Review comment:
It looks strange when part of the parameter is moved to the next line. "(3, 3)" shouldn't' be spitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20406: OneDNN unit test file, small tidy up
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#discussion_r666101862
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -309,15 +319,18 @@ def check_batchnorm_training(stype):
data = mx.symbol.Variable('data', stype=stype)
in_location = [mx.nd.array(data_tmp).tostype(stype), mx.nd.array(gamma).tostype(stype),
mx.nd.array(beta).tostype(stype)]
- mean_std = [mx.nd.array(rolling_mean).tostype(stype), mx.nd.array(rolling_std).tostype(stype)]
+ mean_std = [mx.nd.array(rolling_mean).tostype(
Review comment:
Please have a look at this ~ there are a few fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-877269603
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-879682914
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-879682948
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-876976347
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20406: OneDNN unit test file, small tidy up
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-871473182
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, unix-gpu, unix-cpu, clang, website, windows-gpu, miscellaneous, windows-cpu, sanity, centos-cpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20406: OneDNN unit test file, small tidy up
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#discussion_r666103053
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -405,14 +420,18 @@ def check_pooling_training(stype):
in_location = [mx.nd.array(data_tmp).tostype(stype)]
if np.array(shape).shape[0] == 3:
- test = mx.symbol.Pooling(data=data, kernel=(3), stride=(2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3), stride=(2), pool_type='avg')
elif np.array(shape).shape[0] == 4:
- test = mx.symbol.Pooling(data=data, kernel=(3, 3), stride=(2, 2), pool_type='avg')
+ test = mx.symbol.Pooling(data=data, kernel=(
+ 3, 3), stride=(2, 2), pool_type='avg')
Review comment:
Indeed, max limit was added max-line-length = 120. Should be fine right now. Please have a look at that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-877269576
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406#issuecomment-876976292
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] akarbown merged pull request #20406: Flake8 package checking python coding style: test_mkldnn.py, small tidy up
Posted by GitBox <gi...@apache.org>.
akarbown merged pull request #20406:
URL: https://github.com/apache/incubator-mxnet/pull/20406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org