You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org> on 2007/03/08 01:08:25 UTC
[jira] Closed: (VELOCITY-387) Change legacy HashTable and Vector
instances to Map and List (resourceloader)
[ https://issues.apache.org/jira/browse/VELOCITY-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen closed VELOCITY-387.
-------------------------------------------
> Change legacy HashTable and Vector instances to Map and List (resourceloader)
> -----------------------------------------------------------------------------
>
> Key: VELOCITY-387
> URL: https://issues.apache.org/jira/browse/VELOCITY-387
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.5
> Environment: Operating System: other
> Platform: Other
> Reporter: Mailmur
> Assigned To: Velocity-Dev List
> Priority: Minor
> Attachments: patch.txt
>
>
> From: Mailmur
> org\apache\velocity\runtime\resource\loader\FileResourceLoader.java
> This class uses Vector and Hashtable instances to store cached paths values.
> Should this and other classes be converted to use ArrayList and HashMap
> instances? I think ArrayList+Hashmap give better runtime performance.
> From: Will
> Thanks for catching this. Better yet, good modern practice would also be to
> declare the variables as List and Map. If you'd care to issue a bug report at
> http://issues.apache.org (use BugZilla until we switch to JIRA) this can get
> tracked. If you're feeling ambitious, download svn, get the source and create a
> patch. If "ant test" passes I'll commit it straight away.
> Slight offtopic, see enhancement: #21582
> It uses hashmap and arraylist as an internal members.
> I (mailmur) could fix this, but first I must install Subversion client and study
> creating a patch first. Never done both before. Will keep you posted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org