You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2016/08/19 06:03:07 UTC

Re: logging-log4j2 git commit: Remove unused import.

Gary,

Can you please fix your import static settings?

+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
...
-import static org.junit.Assert.*;



On Fri, Aug 19, 2016 at 1:56 PM, <gg...@apache.org> wrote:

> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/master c4954a872 -> 78764b3e1
>
>
> Remove unused import.
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/78764b3e
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/78764b3e
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/78764b3e
>
> Branch: refs/heads/master
> Commit: 78764b3e16fef9c0a86582ab03146dd033710d47
> Parents: c4954a8
> Author: ggregory <gg...@US-L-GG02.rocketsoftware.com>
> Authored: Thu Aug 18 21:56:50 2016 -0700
> Committer: ggregory <gg...@US-L-GG02.rocketsoftware.com>
> Committed: Thu Aug 18 21:56:50 2016 -0700
>
> ----------------------------------------------------------------------
>  .../apache/logging/log4j/core/layout/PatternLayoutTest.java  | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 78764b3e/log4j-core/src/test/java/org/apache/logging/log4j/
> core/layout/PatternLayoutTest.java
> ----------------------------------------------------------------------
> diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/layout/PatternLayoutTest.java
> b/log4j-core/src/test/java/org/apache/logging/log4j/core/
> layout/PatternLayoutTest.java
> index 43a9167..b4fb905 100644
> --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/
> layout/PatternLayoutTest.java
> +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/
> layout/PatternLayoutTest.java
> @@ -16,6 +16,11 @@
>   */
>  package org.apache.logging.log4j.core.layout;
>
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> +import static org.junit.Assert.assertTrue;
> +
>  import java.nio.ByteBuffer;
>  import java.nio.charset.Charset;
>  import java.nio.charset.StandardCharsets;
> @@ -34,13 +39,10 @@ import org.apache.logging.log4j.core.
> lookup.MainMapLookup;
>  import org.apache.logging.log4j.junit.ThreadContextRule;
>  import org.apache.logging.log4j.message.SimpleMessage;
>  import org.apache.logging.log4j.util.Strings;
> -import org.junit.After;
>  import org.junit.BeforeClass;
>  import org.junit.Rule;
>  import org.junit.Test;
>
> -import static org.junit.Assert.*;
> -
>  /**
>   *
>   */
>
>