You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/08 11:20:38 UTC

[jira] [Commented] (BEAM-1649) Fix unresolved references in Python SDK

    [ https://issues.apache.org/jira/browse/BEAM-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901112#comment-15901112 ] 

ASF GitHub Bot commented on BEAM-1649:
--------------------------------------

GitHub user tibkiss opened a pull request:

    https://github.com/apache/beam/pull/2194

    [BEAM-1649] Fix unresolved references in Python SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tibkiss/beam BEAM-1649

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2194
    
----
commit 8a24f738f48880021304b379529425ade3312418
Author: Tibor Kiss <ti...@gmail.com>
Date:   2017-03-08T11:18:39Z

    [BEAM-1649] Fix unresolved references in Python SDK

----


> Fix unresolved references in Python SDK
> ---------------------------------------
>
>                 Key: BEAM-1649
>                 URL: https://issues.apache.org/jira/browse/BEAM-1649
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>    Affects Versions: 0.6.0
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>
> PyCharm code analyzer revealed usage of unresolved references. 
> This ticket is addressing issues in the following functions:
> {code}
> OrderedPositionRangeTracker.stop_position()
> ValueStateTag.__repr__()
> typehints.decorators._unpack_positional_arg_hints()
> WindowedTypeConstraint.type_check()
> PipelineOptions.__getattr__()
> {code}
> Even though the fixes are trivial keeping the priority as Major since these problems are causing execution errors on their respective code pathes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)