You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Liang-Chi Hsieh (JIRA)" <ji...@apache.org> on 2014/09/02 12:31:20 UTC

[jira] [Created] (SPARK-3345) Do correct parameters for ShuffleFileGroup

Liang-Chi Hsieh created SPARK-3345:
--------------------------------------

             Summary: Do correct parameters for ShuffleFileGroup
                 Key: SPARK-3345
                 URL: https://issues.apache.org/jira/browse/SPARK-3345
             Project: Spark
          Issue Type: Bug
            Reporter: Liang-Chi Hsieh
            Priority: Minor


In the method newFileGroup of class FileShuffleBlockManager, the parameters for creating new ShuffleFileGroup object is in wrong order.

Wrong: new ShuffleFileGroup(fileId, shuffleId, files)
Corrent: new ShuffleFileGroup(shuffleId, fileId, files)

Because in current codes, the parameters shuffleId and fileId are not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org