You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/07/18 22:02:10 UTC

[GitHub] [beam] lostluck opened a new issue, #27549: [Task][Go SDK]: Update datastoreio tests to not rely on direct runner.

lostluck opened a new issue, #27549:
URL: https://github.com/apache/beam/issues/27549

   ### What needs to happen?
   
   The tests rely on overriding the database client with a test interface double, however, it hasn't been done in a serializable form, relying on the Direct Runner to not serialize the DoFns.
   
   eg. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/datastoreio/datastore.go#L44
   
   This is not a good testing style as it isn't possible to execute them on portable runners, like prism, flink, spark, dataflow etc.
   
   Since this requires a bit more thought and code to resolve, datastoreio will continue to use the direct runner as the default for now, but should be changed to an alternative testing means (possibly by a local GRPC connection or similar to a local fake of the service, setting the client endpoint to be overridden, with an API dialing option at client creation https://pkg.go.dev/google.golang.org/api/option#WithEndpoint)
   
   This is used for the native SpannerIO tests, as an example. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/spannerio/common.go#L53
   
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [X] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [X] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task][Go SDK]: Update datastoreio tests to not rely on direct runner. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #27549: [Task][Go SDK]: Update datastoreio tests to not rely on direct runner.
URL: https://github.com/apache/beam/issues/27549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task][Go SDK]: Update datastoreio tests to not rely on direct runner. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27549:
URL: https://github.com/apache/beam/issues/27549#issuecomment-5911721207

   This issue has been closed due to lack of activity. If you think that is incorrect, you can reopen the issue at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task][Go SDK]: Update datastoreio tests to not rely on direct runner. [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27549:
URL: https://github.com/apache/beam/issues/27549#issuecomment-5468741683

   This issue has been marked as stale due to 150 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that’s incorrect or this issue still needs to be addressed, please simply write any comment. If closed, you can reopen the issue at any time. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org